Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-06 Thread David Woodhouse
On Tue, 2013-03-05 at 20:45 -0500, Kevin O'Connor wrote: > > So, I think the question isn't what does real-hardware do (there's no > gain to be had in emulating all of this). Instead, I think the > question is - what makes the most sense. Well,... what we implement for the 'native SeaBIOS on q

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Kevin O'Connor
On Tue, Mar 05, 2013 at 04:59:51PM +, David Woodhouse wrote: > On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: > > Resuming from suspend-to-RAM should not reset all devices. Only the > > CPU should get a reset signal. > > Hm... on reflection, I don't actually know if this is true. >

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Laszlo Ersek
On 03/05/13 20:25, Paolo Bonzini wrote: > Il 05/03/2013 20:12, Laszlo Ersek ha scritto: >> On 03/05/13 17:59, David Woodhouse wrote:> On Tue, 2013-03-05 at 17:03 >> +0100, Paolo Bonzini wrote: Resuming from suspend-to-RAM should not reset all devices. Only the CPU should get a reset sig

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 20:12, Laszlo Ersek ha scritto: > On 03/05/13 17:59, David Woodhouse wrote:> On Tue, 2013-03-05 at 17:03 +0100, > Paolo Bonzini wrote: >>> Resuming from suspend-to-RAM should not reset all devices. Only the >>> CPU should get a reset signal. >> >> Hm... on reflection, I don't actual

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Laszlo Ersek
On 03/05/13 17:59, David Woodhouse wrote:> On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: >> Resuming from suspend-to-RAM should not reset all devices. Only the >> CPU should get a reset signal. > > Hm... on reflection, I don't actually know if this is true. > > Perhaps we *should* reset

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 18:26, Peter Stuge ha scritto: >>> > > That is: perhaps it's a *SeaBIOS* bug that suspend/resume doesn't >>> > > work if the PAM configuration is reset? >> > >> > Yeah, it sounded a bit weird when I wrote that commit message. >> > This could be the case. How does it work on Coreboo

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Peter Stuge
Paolo Bonzini wrote: > > That is: perhaps it's a *SeaBIOS* bug that suspend/resume doesn't > > work if the PAM configuration is reset? > > Yeah, it sounded a bit weird when I wrote that commit message. > This could be the case. How does it work on Coreboot? Yes all hardware except RAM in self-r

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 17:59, David Woodhouse ha scritto: > On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: >> > Resuming from suspend-to-RAM should not reset all devices. Only the >> > CPU should get a reset signal. > Hm... on reflection, I don't actually know if this is true. > > Perhaps we *sho

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread David Woodhouse
On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: > Resuming from suspend-to-RAM should not reset all devices. Only the > CPU should get a reset signal. Hm... on reflection, I don't actually know if this is true. Perhaps we *should* reset all devices. After all, in a real machine they'll a

[Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Paolo Bonzini
Resuming from suspend-to-RAM should not reset all devices. Only the CPU should get a reset signal. Signed-off-by: Paolo Bonzini --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index c03edf1..2c93478 100644 --- a/vl.c +++ b/vl.c @@ -1973,8 +1973,8 @@ stat