Re: [Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event

2018-05-16 Thread Eric Blake
On 05/16/2018 03:46 PM, Kevin Wolf wrote: +{ 'event': 'JOB_STATUS_CHANGE', + 'data': { 'id': 'str', +'status': 'JobStatus' } } Is it worth also trying to list the old state that the transition came from? But that's new compared to what block jobs are currently doing, so if we can'

Re: [Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event

2018-05-16 Thread Kevin Wolf
Am 16.05.2018 um 21:26 hat Eric Blake geschrieben: > On 05/09/2018 11:26 AM, Kevin Wolf wrote: > > This adds a QMP event that is emitted whenever a job transitions from > > one status to another. For the event, a new qapi/job.json schema file is > > created which will contain all job-related defini

Re: [Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event

2018-05-16 Thread Eric Blake
On 05/09/2018 11:26 AM, Kevin Wolf wrote: This adds a QMP event that is emitted whenever a job transitions from one status to another. For the event, a new qapi/job.json schema file is created which will contain all job-related definitions that aren't tied to the block layer. Signed-off-by: Kevi

Re: [Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event

2018-05-16 Thread Kevin Wolf
Am 15.05.2018 um 00:11 hat Max Reitz geschrieben: > You forgot to adjust 094, and although I cannot prove it (I don't have > an nfs setup handy right now), I have a hunch that this patch breaks 173 > as well. NFS qemu-iotests look completely broken. And the block driver, too. I've sent a fix for t

Re: [Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event

2018-05-14 Thread Max Reitz
On 2018-05-09 18:26, Kevin Wolf wrote: > This adds a QMP event that is emitted whenever a job transitions from > one status to another. For the event, a new qapi/job.json schema file is > created which will contain all job-related definitions that aren't tied > to the block layer. > > Signed-off-b

[Qemu-devel] [PATCH 38/42] job: Add JOB_STATUS_CHANGE QMP event

2018-05-09 Thread Kevin Wolf
This adds a QMP event that is emitted whenever a job transitions from one status to another. For the event, a new qapi/job.json schema file is created which will contain all job-related definitions that aren't tied to the block layer. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 4