Re: [Qemu-devel] [PATCH 36/39] memory: move bitmap synchronization to its own function

2013-12-18 Thread Alexander Graf
On 06.11.2013, at 17:22, Juan Quintela wrote: > Paolo Bonzini wrote: >> Il 06/11/2013 14:04, Juan Quintela ha scritto: >>> We want to have all the functions that handle directly the dirty >>> bitmap near. We will change it later. >> >> Please move it to exec.c instead. >> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH 36/39] memory: move bitmap synchronization to its own function

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 17:22, Juan Quintela ha scritto: >>> >> >>> >> +static inline void cpu_physical_memory_set_dirty_lebitmap(unsigned long >>> >> *bitmap, >> > >> > Why "le"? > little endian, name is already too long (cpu_physical_memory_ is too > big as a preffix.) > Yeah, I just found we have a m

Re: [Qemu-devel] [PATCH 36/39] memory: move bitmap synchronization to its own function

2013-11-06 Thread Juan Quintela
Paolo Bonzini wrote: > Il 06/11/2013 14:04, Juan Quintela ha scritto: >> We want to have all the functions that handle directly the dirty >> bitmap near. We will change it later. > > Please move it to exec.c instead. > >> Signed-off-by: Juan Quintela >> --- >> include/exec/memory-physical.h | 3

Re: [Qemu-devel] [PATCH 36/39] memory: move bitmap synchronization to its own function

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 14:04, Juan Quintela ha scritto: > We want to have all the functions that handle directly the dirty > bitmap near. We will change it later. Please move it to exec.c instead. > Signed-off-by: Juan Quintela > --- > include/exec/memory-physical.h | 31 +++

[Qemu-devel] [PATCH 36/39] memory: move bitmap synchronization to its own function

2013-11-06 Thread Juan Quintela
We want to have all the functions that handle directly the dirty bitmap near. We will change it later. Signed-off-by: Juan Quintela --- include/exec/memory-physical.h | 31 +++ kvm-all.c | 27 ++- 2 files changed, 33 inser