Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Thomas Huth
On 14/12/15 23:06, Samuel Thibault wrote: > Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote: >>> +default: >>> +/* Do not assert while we don't manage IP6VERSION */ >>> +/* assert(0); */ >> >> Not sure if we ever want to have an assert() here - since I assume this >> could

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Samuel Thibault
Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote: > > +default: > > +/* Do not assert while we don't manage IP6VERSION */ > > +/* assert(0); */ > > Not sure if we ever want to have an assert() here - since I assume this > could be triggered by the guest? No, this is if_en

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Samuel Thibault
Samuel Thibault, on Mon 14 Dec 2015 23:06:16 +0100, wrote: > Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote: > > > +default: > > > +/* Do not assert while we don't manage IP6VERSION */ > > > +/* assert(0); */ > > > > Not sure if we ever want to have an assert() here - si

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Thomas Huth
On 14/12/15 14:51, Samuel Thibault wrote: > From: Guillaume Subiron > > In if_encap, a switch is added to prepare for the IPv6 case. Some code > is factorized. > > This prepares for IPv6 support. > > Signed-off-by: Guillaume Subiron > Signed-off-by: Samuel Thibault > --- > slirp/slirp.c | 61

[Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Samuel Thibault
From: Guillaume Subiron In if_encap, a switch is added to prepare for the IPv6 case. Some code is factorized. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/slirp.c | 61 ++- 1