Re: [Qemu-devel] [PATCH 3/9] qapi: remove error checks for event emission

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 10:43:13AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > In the whole QAPI event emission code we're passing in an Error* object > > along the whole stack. That's never useful since it never fails after > > all. Remove that. > > > > Then, remove that parameter

Re: [Qemu-devel] [PATCH 3/9] qapi: remove error checks for event emission

2018-07-05 Thread Markus Armbruster
Peter Xu writes: > In the whole QAPI event emission code we're passing in an Error* object > along the whole stack. That's never useful since it never fails after > all. Remove that. > > Then, remove that parameter from all the callers to send an event. > > Suggested-by: Eric Blake > Suggested

[Qemu-devel] [PATCH 3/9] qapi: remove error checks for event emission

2018-07-04 Thread Peter Xu
In the whole QAPI event emission code we're passing in an Error* object along the whole stack. That's never useful since it never fails after all. Remove that. Then, remove that parameter from all the callers to send an event. Suggested-by: Eric Blake Suggested-by: Markus Armbruster Signed-of