Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-07-01 Thread Paolo Bonzini
On 01/07/2015 18:06, Peter Hornyack wrote: > If userspace is controlling the crash capabilities then > HV_X64_MSR_CRASH_CTL_CONTENTS is not needed. Actually you still need to: userspace cannot write anything but 0 or (1ULL << 63). However, the name makes less sense, so I'm in favor of removing

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-07-01 Thread Peter Hornyack
If userspace is controlling the crash capabilities then HV_X64_MSR_CRASH_CTL_CONTENTS is not needed. On Wed, Jul 1, 2015 at 8:53 AM, Denis V. Lunev wrote: > On 01/07/15 18:00, Paolo Bonzini wrote: >> >> >> On 30/06/2015 13:33, Denis V. Lunev wrote: >>> >>> +#define HV_X64_MSR_CRASH_CTL_NOTIFY

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-07-01 Thread Denis V. Lunev
On 01/07/15 18:00, Paolo Bonzini wrote: On 30/06/2015 13:33, Denis V. Lunev wrote: +#define HV_X64_MSR_CRASH_CTL_NOTIFY(1ULL << 63) +#define HV_X64_MSR_CRASH_CTL_CONTENTS \ + (HV_X64_MSR_CRASH_CTL_NOTIFY) Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed? Can I just remov

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-07-01 Thread Paolo Bonzini
On 30/06/2015 13:33, Denis V. Lunev wrote: > +#define HV_X64_MSR_CRASH_CTL_NOTIFY (1ULL << 63) > +#define HV_X64_MSR_CRASH_CTL_CONTENTS\ > + (HV_X64_MSR_CRASH_CTL_NOTIFY) Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed? Can I just remove it? Paolo

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-06-30 Thread Peter Hornyack
On Tue, Jun 30, 2015 at 4:33 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > Added Hyper-V crash msrs values - HV_X64_MSR_CRASH*. > > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Gleb Natapov Reviewed-by: Peter Hornyack > --- > arch/x86/inc

[Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-06-30 Thread Denis V. Lunev
From: Andrey Smetanin Added Hyper-V crash msrs values - HV_X64_MSR_CRASH*. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Gleb Natapov --- arch/x86/include/uapi/asm/hyperv.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/x86/inc