On 06/12/2014 06:26 AM, Benoît Canet wrote:
>> +static QDict *parse_json_filename(const char *filename, Error **errp)
>> +{
>
> I am under the impression that this code move could be avoided by using a
> function
> prototype: the patch would be less cluttered.
I'm a fan of avoiding function pr
The Wednesday 11 Jun 2014 à 16:04:57 (+0200), Kevin Wolf wrote :
> Signed-off-by: Kevin Wolf
> ---
> block.c | 88
> +
> 1 file changed, 45 insertions(+), 43 deletions(-)
>
> diff --git a/block.c b/block.c
> index effb3e6..b9c2b41
On 06/11/2014 08:04 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> block.c | 88
> +
> 1 file changed, 45 insertions(+), 43 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Lib
Signed-off-by: Kevin Wolf
---
block.c | 88 +
1 file changed, 45 insertions(+), 43 deletions(-)
diff --git a/block.c b/block.c
index effb3e6..b9c2b41 100644
--- a/block.c
+++ b/block.c
@@ -1006,19 +1006,62 @@ free_and_fail:
ret
