Re: [Qemu-devel] [PATCH 3/8] vmdk: clean up open

2011-10-20 Thread Kevin Wolf
Am 20.10.2011 12:12, schrieb Paolo Bonzini: > On 10/20/2011 11:28 AM, Kevin Wolf wrote: >> This code is moved into bdrv_open, but there's another path how this >> code can be reached: >> >> vmdk_parse_extents() -> vmdk_open_sparse() -> vmdk_open_vmdk4() -> >> vmdk_open_desc_file(). >> >> Don't we

Re: [Qemu-devel] [PATCH 3/8] vmdk: clean up open

2011-10-20 Thread Paolo Bonzini
On 10/20/2011 11:28 AM, Kevin Wolf wrote: > This code is moved into bdrv_open, but there's another path how this > code can be reached: > > vmdk_parse_extents() -> vmdk_open_sparse() -> vmdk_open_vmdk4() -> > vmdk_open_desc_file(). > > Don't we forget to open the parent file there now? Let's l

Re: [Qemu-devel] [PATCH 3/8] vmdk: clean up open

2011-10-20 Thread Kevin Wolf
Am 19.10.2011 16:59, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > block/vmdk.c | 37 +++-- > 1 files changed, 15 insertions(+), 22 deletions(-) > > diff --git a/block/vmdk.c b/block/vmdk.c > index 21566eb..12b38d2 100644 > --- a/block/vmdk.c > +

[Qemu-devel] [PATCH 3/8] vmdk: clean up open

2011-10-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/vmdk.c | 37 +++-- 1 files changed, 15 insertions(+), 22 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 21566eb..12b38d2 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -622,20 +622,7 @@ static int vmdk_open_de