Re: [Qemu-devel] [PATCH 3/8] target-ppc: Bug Fix: rlwimi

2014-08-18 Thread Tom Musta
On 8/15/2014 3:05 PM, Richard Henderson wrote: > On 08/11/2014 09:23 AM, Tom Musta wrote: >> Also fix the special case of MB=31 and ME=0 to copy the entire contents >> of the source GPR. > > Err, that's not what you did. > >> if (likely(sh == 0 && mb == 0 && me == 31)) { >> +#if defined(TARG

Re: [Qemu-devel] [PATCH 3/8] target-ppc: Bug Fix: rlwimi

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > Also fix the special case of MB=31 and ME=0 to copy the entire contents > of the source GPR. Err, that's not what you did. > if (likely(sh == 0 && mb == 0 && me == 31)) { > +#if defined(TARGET_PPC64) > +tcg_gen_mov_i64(cpu_gpr[rA(ctx->opcode

[Qemu-devel] [PATCH 3/8] target-ppc: Bug Fix: rlwimi

2014-08-11 Thread Tom Musta
The rlwimi specification includes the ROTL32 operation, which is defined to be a left rotation of two copies of the least significant 32 bits of the source GPR. The current implementation is incorrect on 64-bit implementations in that it rotates a single copy of the least significant 32 bits, padd