Re: [Qemu-devel] [PATCH 3/6] virtio-pci: fix 1.0 virtqueue migration

2015-08-24 Thread Jason Wang
On 08/24/2015 10:14 PM, Cornelia Huck wrote: > On Mon, 24 Aug 2015 13:37:06 +0800 > Jason Wang wrote: > >> On 08/21/2015 05:43 PM, Cornelia Huck wrote: >>> On Fri, 21 Aug 2015 17:05:47 +0800 >>> Jason Wang wrote: +k->has_modern_state && +k->has_modern_state(qbus->paren

Re: [Qemu-devel] [PATCH 3/6] virtio-pci: fix 1.0 virtqueue migration

2015-08-24 Thread Cornelia Huck
On Mon, 24 Aug 2015 13:37:06 +0800 Jason Wang wrote: > On 08/21/2015 05:43 PM, Cornelia Huck wrote: > > On Fri, 21 Aug 2015 17:05:47 +0800 > > Jason Wang wrote: > >> +k->has_modern_state && > >> +k->has_modern_state(qbus->parent); > >> +} > > I don't really like this "modern_sta

Re: [Qemu-devel] [PATCH 3/6] virtio-pci: fix 1.0 virtqueue migration

2015-08-24 Thread Jason Wang
On 08/21/2015 05:43 PM, Cornelia Huck wrote: > On Fri, 21 Aug 2015 17:05:47 +0800 > Jason Wang wrote: > >> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c >> index 788b556..c971ba2 100644 >> --- a/hw/virtio/virtio.c >> +++ b/hw/virtio/virtio.c >> @@ -1056,6 +1056,17 @@ static bool virtio_vi

Re: [Qemu-devel] [PATCH 3/6] virtio-pci: fix 1.0 virtqueue migration

2015-08-21 Thread Cornelia Huck
On Fri, 21 Aug 2015 17:05:47 +0800 Jason Wang wrote: > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 788b556..c971ba2 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -1056,6 +1056,17 @@ static bool virtio_virtqueue_needed(void *opaque) > return virtio_host_ha

[Qemu-devel] [PATCH 3/6] virtio-pci: fix 1.0 virtqueue migration

2015-08-21 Thread Jason Wang
We don't migrate the followings fields for virtio-pci: uint32_t dfselect; uint32_t gfselect; uint32_t guest_features[2]; struct { uint16_t num; bool enabled; uint32_t desc[2]; uint32_t avail[2]; uint32_t used[2]; } vqs[VIRTIO_QUEUE_MAX]; This will confuse driver if migrating d