Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Igor Mammedov
On Wed, 8 Apr 2015 12:01:26 -0300 Eduardo Habkost wrote: > On Wed, Apr 08, 2015 at 04:09:32PM +0200, Igor Mammedov wrote: > > On Wed, 08 Apr 2015 14:24:35 +0200 > > Paolo Bonzini wrote: > > > > > > > > > > > On 08/04/2015 14:20, Eduardo Habkost wrote: > > > >> > it would be better to create g

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Eduardo Habkost
On Wed, Apr 08, 2015 at 04:09:32PM +0200, Igor Mammedov wrote: > On Wed, 08 Apr 2015 14:24:35 +0200 > Paolo Bonzini wrote: > > > > > > > On 08/04/2015 14:20, Eduardo Habkost wrote: > > >> > it would be better to create generic bit property and replace above > > >> > code with it > > >> > somet

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Igor Mammedov
On Wed, 08 Apr 2015 14:24:35 +0200 Paolo Bonzini wrote: > > > On 08/04/2015 14:20, Eduardo Habkost wrote: > >> > it would be better to create generic bit property and replace above code > >> > with it > >> > something similar to object_property_add_uint32_ptr() > > object_property_add_*_ptr()

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Andreas Färber
Am 08.04.2015 um 13:06 schrieb Eduardo Habkost: > On Wed, Apr 08, 2015 at 10:30:52AM +0200, Paolo Bonzini wrote: >> On 07/04/2015 22:46, Eduardo Habkost wrote: >>> This uses the feature name arrays to register "feat-*" QOM properties >>> for feature flags. This simply adds the properties so they ca

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Paolo Bonzini
On 08/04/2015 14:20, Eduardo Habkost wrote: >> > it would be better to create generic bit property and replace above code >> > with it >> > something similar to object_property_add_uint32_ptr() > object_property_add_*_ptr() adds read-only properties, and I didn't want > to make object_property_a

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Eduardo Habkost
On Wed, Apr 08, 2015 at 01:36:29PM +0200, Igor Mammedov wrote: > On Tue, 7 Apr 2015 17:46:40 -0300 > Eduardo Habkost wrote: > > > This uses the feature name arrays to register "feat-*" QOM properties > > for feature flags. This simply adds the properties so they can be > > configured using -glob

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Igor Mammedov
On Tue, 7 Apr 2015 17:46:40 -0300 Eduardo Habkost wrote: > This uses the feature name arrays to register "feat-*" QOM properties > for feature flags. This simply adds the properties so they can be > configured using -global, but doesn't change x86_cpu_parse_featurestr() > to use them yet. > > S

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Eduardo Habkost
On Wed, Apr 08, 2015 at 10:30:52AM +0200, Paolo Bonzini wrote: > > > On 07/04/2015 22:46, Eduardo Habkost wrote: > > This uses the feature name arrays to register "feat-*" QOM properties > > for feature flags. This simply adds the properties so they can be > > configured using -global, but doesn'

Re: [Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:46, Eduardo Habkost wrote: > This uses the feature name arrays to register "feat-*" QOM properties > for feature flags. This simply adds the properties so they can be > configured using -global, but doesn't change x86_cpu_parse_featurestr() > to use them yet. Out of curiosity, w

[Qemu-devel] [PATCH 3/6] target-i386: Register QOM properties for feature flags

2015-04-07 Thread Eduardo Habkost
This uses the feature name arrays to register "feat-*" QOM properties for feature flags. This simply adds the properties so they can be configured using -global, but doesn't change x86_cpu_parse_featurestr() to use them yet. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 98 +