Re: [Qemu-devel] [PATCH 3/5] vmdk: Implement .bdrv_co_create callback

Fam Zheng writes: > On Wed, 05/09 14:41, Markus Armbruster wrote: >> Beware, I'm only looking at QAPI-related aspects. >> >> Fam Zheng writes: >> >> > This makes VMDK support x-blockdev-create. The implementation reuses the >> > image creation code in vmdk_co_create_opts which now acceptes a c

Re: [Qemu-devel] [PATCH 3/5] vmdk: Implement .bdrv_co_create callback

On Wed, 05/09 14:41, Markus Armbruster wrote: > Beware, I'm only looking at QAPI-related aspects. > > Fam Zheng writes: > > > This makes VMDK support x-blockdev-create. The implementation reuses the > > image creation code in vmdk_co_create_opts which now acceptes a callback > > pointer to "retr

Re: [Qemu-devel] [PATCH 3/5] vmdk: Implement .bdrv_co_create callback

Beware, I'm only looking at QAPI-related aspects. Fam Zheng writes: > This makes VMDK support x-blockdev-create. The implementation reuses the > image creation code in vmdk_co_create_opts which now acceptes a callback > pointer to "retrieve" BlockBackend pointers from the caller. This way we > s

[Qemu-devel] [PATCH 3/5] vmdk: Implement .bdrv_co_create callback

This makes VMDK support x-blockdev-create. The implementation reuses the image creation code in vmdk_co_create_opts which now acceptes a callback pointer to "retrieve" BlockBackend pointers from the caller. This way we separate the logic between file/extent acquisition and initialization. The QAPI