Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-16 Thread David Gibson
On Fri, Jun 15, 2018 at 03:24:18PM +0200, Greg Kurz wrote: > On Fri, 15 Jun 2018 22:32:44 +1000 > David Gibson wrote: > > > On Fri, Jun 15, 2018 at 10:01:47AM +0200, Greg Kurz wrote: > > > On Fri, 15 Jun 2018 09:07:24 +0200 > > > Greg Kurz wrote: > > > > > > > On Fri, 15 Jun 2018 16:29:15 +10

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-15 Thread Greg Kurz
On Fri, 15 Jun 2018 22:32:44 +1000 David Gibson wrote: > On Fri, Jun 15, 2018 at 10:01:47AM +0200, Greg Kurz wrote: > > On Fri, 15 Jun 2018 09:07:24 +0200 > > Greg Kurz wrote: > > > > > On Fri, 15 Jun 2018 16:29:15 +1000 > > > David Gibson wrote: > > > > > > > On Fri, Jun 15, 2018 at 07:5

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-15 Thread David Gibson
On Fri, Jun 15, 2018 at 10:01:47AM +0200, Greg Kurz wrote: > On Fri, 15 Jun 2018 09:07:24 +0200 > Greg Kurz wrote: > > > On Fri, 15 Jun 2018 16:29:15 +1000 > > David Gibson wrote: > > > > > On Fri, Jun 15, 2018 at 07:58:05AM +0200, Greg Kurz wrote: > > > > On Fri, 15 Jun 2018 10:14:31 +1000 >

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-15 Thread Greg Kurz
On Fri, 15 Jun 2018 09:07:24 +0200 Greg Kurz wrote: > On Fri, 15 Jun 2018 16:29:15 +1000 > David Gibson wrote: > > > On Fri, Jun 15, 2018 at 07:58:05AM +0200, Greg Kurz wrote: > > > On Fri, 15 Jun 2018 10:14:31 +1000 > > > David Gibson wrote: > > > > > > > On Fri, Jun 15, 2018 at 10:02:

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-15 Thread Greg Kurz
On Fri, 15 Jun 2018 16:29:15 +1000 David Gibson wrote: > On Fri, Jun 15, 2018 at 07:58:05AM +0200, Greg Kurz wrote: > > On Fri, 15 Jun 2018 10:14:31 +1000 > > David Gibson wrote: > > > > > On Fri, Jun 15, 2018 at 10:02:25AM +1000, David Gibson wrote: > > > > On Thu, Jun 14, 2018 at 11:50:42

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-14 Thread David Gibson
On Fri, Jun 15, 2018 at 07:53:37AM +0200, Greg Kurz wrote: > On Fri, 15 Jun 2018 10:02:25 +1000 > David Gibson wrote: > > > On Thu, Jun 14, 2018 at 11:50:42PM +0200, Greg Kurz wrote: > > > The spapr_realize_vcpu() function doesn't rollback in case of error. > > > This isn't a problem with coldplu

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-14 Thread David Gibson
On Fri, Jun 15, 2018 at 07:58:05AM +0200, Greg Kurz wrote: > On Fri, 15 Jun 2018 10:14:31 +1000 > David Gibson wrote: > > > On Fri, Jun 15, 2018 at 10:02:25AM +1000, David Gibson wrote: > > > On Thu, Jun 14, 2018 at 11:50:42PM +0200, Greg Kurz wrote: > > > > The spapr_realize_vcpu() function do

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-14 Thread Greg Kurz
On Fri, 15 Jun 2018 10:14:31 +1000 David Gibson wrote: > On Fri, Jun 15, 2018 at 10:02:25AM +1000, David Gibson wrote: > > On Thu, Jun 14, 2018 at 11:50:42PM +0200, Greg Kurz wrote: > > > The spapr_realize_vcpu() function doesn't rollback in case of error. > > > This isn't a problem with coldpl

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-14 Thread Greg Kurz
On Fri, 15 Jun 2018 10:02:25 +1000 David Gibson wrote: > On Thu, Jun 14, 2018 at 11:50:42PM +0200, Greg Kurz wrote: > > The spapr_realize_vcpu() function doesn't rollback in case of error. > > This isn't a problem with coldplugged CPUs because the machine won't > > start and QEMU will exit. Hotpl

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-14 Thread David Gibson
On Fri, Jun 15, 2018 at 10:02:25AM +1000, David Gibson wrote: > On Thu, Jun 14, 2018 at 11:50:42PM +0200, Greg Kurz wrote: > > The spapr_realize_vcpu() function doesn't rollback in case of error. > > This isn't a problem with coldplugged CPUs because the machine won't > > start and QEMU will exit.

Re: [Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-14 Thread David Gibson
On Thu, Jun 14, 2018 at 11:50:42PM +0200, Greg Kurz wrote: > The spapr_realize_vcpu() function doesn't rollback in case of error. > This isn't a problem with coldplugged CPUs because the machine won't > start and QEMU will exit. Hotplug is a different story though: the > CPU thread is started under

[Qemu-devel] [PATCH 3/5] spapr_cpu_core: add missing rollback on realization path

2018-06-14 Thread Greg Kurz
The spapr_realize_vcpu() function doesn't rollback in case of error. This isn't a problem with coldplugged CPUs because the machine won't start and QEMU will exit. Hotplug is a different story though: the CPU thread is started under object_property_set_bool() and it assumes it can access the CPU ob