[Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()

2011-10-09 Thread Juan Quintela
Signed-off-by: Juan Quintela Signed-off-by: Juan Quintela --- savevm.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/savevm.c b/savevm.c index 4069b34..94628c6 100644 --- a/savevm.c +++ b/savevm.c @@ -578,17 +578,14 @@ static int qemu_peek_byte(QEMUFile *f

[Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()

2011-10-07 Thread Juan Quintela
Signed-off-by: Juan Quintela Signed-off-by: Juan Quintela --- savevm.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/savevm.c b/savevm.c index 4069b34..94628c6 100644 --- a/savevm.c +++ b/savevm.c @@ -578,17 +578,14 @@ static int qemu_peek_byte(QEMUFile *f

Re: [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()

2011-10-06 Thread Juan Quintela
Paolo Bonzini wrote: > On 10/06/2011 06:21 PM, Juan Quintela wrote: >> +result = qemu_peek_byte(f); >> + >> +if (f->buf_index< f->buf_size) { >> +f->buf_index++; >> } > > This should really be an assert that f->buf_index < f->buf_size, > otherwise qemu_peek_byte has read gar

Re: [Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()

2011-10-06 Thread Paolo Bonzini
On 10/06/2011 06:21 PM, Juan Quintela wrote: +result = qemu_peek_byte(f); + +if (f->buf_index< f->buf_size) { +f->buf_index++; } This should really be an assert that f->buf_index < f->buf_size, otherwise qemu_peek_byte has read garbage. Paolo

[Qemu-devel] [PATCH 3/5] savevm: define qemu_get_byte() using qemu_peek_byte()

2011-10-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- savevm.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/savevm.c b/savevm.c index 4069b34..94628c6 100644 --- a/savevm.c +++ b/savevm.c @@ -578,17 +578,14 @@ static int qemu_peek_byte(QEMUFile *f) int qemu_get_byte(QEMUFil