Re: [Qemu-devel] [PATCH 3/5] gtk: Fix -serial vc

2014-04-25 Thread Gerd Hoffmann
> > -qemu_chr_be_write(vc->chr, buffer, len); > > +VirtualConsole *vc = user_data; > > Gerd, can we retain the white line here please? :) > > Andreas > > > +qemu_chr_be_write(vc->chr, (uint8_t *)text, (unsigned int)size); Fixed in my local copy. cheers, Gerd

Re: [Qemu-devel] [PATCH 3/5] gtk: Fix -serial vc

2014-04-25 Thread Andreas Färber
Am 24.04.2014 19:35, schrieb Cole Robinson: > Try kicking off a rhel5 text install over serial, the text menu navigation > is all messed up, and some of the kernel boot messages are randomly > corrupted. > > Drop use of a pty and just use vte infrastructure for reading and writing. > This fixes th

Re: [Qemu-devel] [PATCH 3/5] gtk: Fix -serial vc

2014-04-25 Thread Gerd Hoffmann
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote: > Drop use of a pty and just use vte infrastructure for reading and > writing. Makes perfect sense. pty is poinless in our vte usage szenario. cheers, Gerd

[Qemu-devel] [PATCH 3/5] gtk: Fix -serial vc

2014-04-24 Thread Cole Robinson
Try kicking off a rhel5 text install over serial, the text menu navigation is all messed up, and some of the kernel boot messages are randomly corrupted. Drop use of a pty and just use vte infrastructure for reading and writing. This fixes the above corruption, and is simpler to boot. (I don't kn