Re: [Qemu-devel] [PATCH 3/4] vhost-user: add protocol feature negotiation

2015-07-22 Thread Marc-André Lureau
Hi On Fri, Jul 17, 2015 at 4:09 PM, Michael S. Tsirkin wrote: > > +#define VHOST_USER_F_PROTOCOL_FEATURES 30 > +#define VHOST_USER_PROTOCOL_FEATURE_MASK 0x0ULL Since this flag is among the VHOST_GET_FEATURES, shouldn't it be part of linux-headers/linux/vhost.h ? (next to VHOST_F_LOG_ALL and VHOS

Re: [Qemu-devel] [PATCH 3/4] vhost-user: add protocol feature negotiation

2015-07-17 Thread Flavio Leitner
On Fri, Jul 17, 2015 at 05:09:38PM +0300, Michael S. Tsirkin wrote: > Support a separate bitmask for vhost-user protocol features, > and messages to get/set protocol features. > > Invoke them at init. > > No features are defined yet. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/vir

[Qemu-devel] [PATCH 3/4] vhost-user: add protocol feature negotiation

2015-07-17 Thread Michael S. Tsirkin
Support a separate bitmask for vhost-user protocol features, and messages to get/set protocol features. Invoke them at init. No features are defined yet. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/vhost.h | 1 + hw/net/vhost_net.c| 2 ++ hw/virtio/vhost-user.c| 52 ++