Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-26 Thread Laszlo Ersek
On 04/25/19 12:23, Philippe Mathieu-Daudé wrote: > On 4/25/19 10:29 AM, Li Qiang wrote: >> >> >> Gerd Hoffmann mailto:kra...@redhat.com>> 于2019年4月 >> 25日周四 下午4:15写道: >> >> On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote: >> > Thomas Huth mailto:th...@redhat.com>> 于2019年4 >> 月24

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-26 Thread Laszlo Ersek
On 04/25/19 10:15, Gerd Hoffmann wrote: > On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote: >> Thomas Huth 于2019年4月24日周三 上午12:29写道: >> >>> Is this endianess-safe? Or do you need to byteswap reboot_timeout if the >>> host and guest endianess does not match? >> >> Good question! >> >> IIUC,

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 10:29 AM, Li Qiang wrote: > > > Gerd Hoffmann mailto:kra...@redhat.com>> 于2019年4月 > 25日周四 下午4:15写道: > > On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote: > > Thomas Huth mailto:th...@redhat.com>> 于2019年4 > 月24日周三 上午12:29写道: > > > > > Is this endianess-safe?

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-25 Thread Li Qiang
Gerd Hoffmann 于2019年4月25日周四 下午4:15写道: > On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote: > > Thomas Huth 于2019年4月24日周三 上午12:29写道: > > > > > Is this endianess-safe? Or do you need to byteswap reboot_timeout if > the > > > host and guest endianess does not match? > > > > Good question! >

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-25 Thread Gerd Hoffmann
On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote: > Thomas Huth 于2019年4月24日周三 上午12:29写道: > > > Is this endianess-safe? Or do you need to byteswap reboot_timeout if the > > host and guest endianess does not match? > > Good question! > > IIUC, the qemu fw_cfg store the 'file' entry data j

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-24 Thread Li Qiang
Thomas Huth 于2019年4月24日周三 下午3:31写道: > On 24/04/2019 03.16, Li Qiang wrote: > > > > Thomas Huth mailto:th...@redhat.com>> 于2019年4月24日 > > 周三 上午12:29写道: > > > > On 20/04/2019 12.00, Li Qiang wrote: > > > Signed-off-by: Li Qiang mailto:liq...@163.com>> > > > --- > > > tests/fw_cfg-t

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-24 Thread Li Qiang
Thomas Huth 于2019年4月24日周三 下午3:31写道: > On 24/04/2019 03.16, Li Qiang wrote: > > > > Thomas Huth mailto:th...@redhat.com>> 于2019年4月24日 > > 周三 上午12:29写道: > > > > On 20/04/2019 12.00, Li Qiang wrote: > > > Signed-off-by: Li Qiang mailto:liq...@163.com>> > > > --- > > > tests/fw_cfg-t

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-24 Thread Thomas Huth
On 24/04/2019 03.16, Li Qiang wrote: > > Thomas Huth mailto:th...@redhat.com>> 于2019年4月24日 > 周三 上午12:29写道: > > On 20/04/2019 12.00, Li Qiang wrote: > > Signed-off-by: Li Qiang mailto:liq...@163.com>> > > --- > >  tests/fw_cfg-test.c | 19 +++ > >  1 file changed

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-23 Thread Li Qiang
Thomas Huth 于2019年4月24日周三 上午12:29写道: > On 20/04/2019 12.00, Li Qiang wrote: > > Signed-off-by: Li Qiang > > --- > > tests/fw_cfg-test.c | 19 +++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > > index c22503619f..9f75dbb5f4

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-23 Thread Thomas Huth
On 20/04/2019 12.00, Li Qiang wrote: > Signed-off-by: Li Qiang > --- > tests/fw_cfg-test.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > index c22503619f..9f75dbb5f4 100644 > --- a/tests/fw_cfg-test.c > +++ b/tests/fw_cf

[Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-20 Thread Li Qiang
Signed-off-by: Li Qiang --- tests/fw_cfg-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c index c22503619f..9f75dbb5f4 100644 --- a/tests/fw_cfg-test.c +++ b/tests/fw_cfg-test.c @@ -174,6 +174,24 @@ static void test_fw_cfg_b