Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-07 Thread Dr. David Alan Gilbert
* Jens Freimann (jfreim...@redhat.com) wrote: > On Tue, Jun 04, 2019 at 08:00:19PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Tue, Jun 04, 2019 at 03:43:21PM +0200, Jens Freimann wrote: > > > > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Ha

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-07 Thread Michael S. Tsirkin
On Fri, Jun 07, 2019 at 04:14:07PM +0200, Jens Freimann wrote: > On Tue, Jun 04, 2019 at 08:00:19PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Tue, Jun 04, 2019 at 03:43:21PM +0200, Jens Freimann wrote: > > > > On Mon, Jun 03, 2019 at 04:36:48PM

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-07 Thread Jens Freimann
On Tue, Jun 04, 2019 at 08:00:19PM +0100, Dr. David Alan Gilbert wrote: * Michael S. Tsirkin (m...@redhat.com) wrote: On Tue, Jun 04, 2019 at 03:43:21PM +0200, Jens Freimann wrote: > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: > > On Mon, Jun 03, 2019 at 10:24:56AM +0200, Je

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-06 Thread Roman Kagan
On Mon, Jun 03, 2019 at 12:46:52PM -0600, Alex Williamson wrote: > On Mon, 3 Jun 2019 14:10:52 -0400 > Laine Stump wrote: > > > On 6/3/19 4:24 AM, Jens Freimann wrote: > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > > >> On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Fr

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 12:04:28PM -0400, Laine Stump wrote: > On 6/4/19 9:43 AM, Jens Freimann wrote: > > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: > > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Laine Stump
On 6/4/19 9:43 AM, Jens Freimann wrote: On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrot

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Daniel P . Berrangé
On Thu, May 30, 2019 at 02:09:42PM -0400, Michael S. Tsirkin wrote: > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > > Hi David, > > > > > > > > sor

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Daniel P . Berrangé
On Mon, Jun 03, 2019 at 12:46:52PM -0600, Alex Williamson wrote: > On Mon, 3 Jun 2019 14:10:52 -0400 > Laine Stump wrote: > > > On 6/3/19 4:24 AM, Jens Freimann wrote: > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > > >> On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Fr

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Daniel P . Berrangé
On Tue, Jun 04, 2019 at 03:43:21PM +0200, Jens Freimann wrote: > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: > > On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > > > > On Thu, May 30, 2019 at

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-04 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Jun 04, 2019 at 03:43:21PM +0200, Jens Freimann wrote: > > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: > > > > On Fri, May 31, 2019 at 06:47:48PM -0300,

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2019 at 03:43:21PM +0200, Jens Freimann wrote: > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: > > On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > > > > On Thu, May 30, 2019 at

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-04 Thread Eduardo Habkost
On Tue, Jun 04, 2019 at 03:43:21PM +0200, Jens Freimann wrote: > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: > > On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > > > > On Thu, May 30, 2019 at

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-04 Thread Jens Freimann
On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > On Tue, May 28, 2019 at 11:04:15AM

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-03 Thread Eduardo Habkost
On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, May 21, 2019

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-03 Thread Alex Williamson
On Mon, 3 Jun 2019 14:10:52 -0400 Laine Stump wrote: > On 6/3/19 4:24 AM, Jens Freimann wrote: > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > >> On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > >>> On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Ts

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-03 Thread Laine Stump
On 6/3/19 4:24 AM, Jens Freimann wrote: On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-03 Thread Jens Freimann
On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: On Tue, May 21, 2019 at 10:45:05AM

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-03 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Fri, 31 May 2019 19:45:13 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > > Yes. It's just lots of extremely low

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-03 Thread Jens Freimann
On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: > > * Jens Freimann (jfrei

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-03 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, May 31, 2019 at 07:45:13PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > > Yes. It's just lots of extremely low level inter

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Fri, May 31, 2019 at 05:05:26PM -0400, Michael S. Tsirkin wrote: > On Fri, May 31, 2019 at 02:29:33PM -0600, Alex Williamson wrote: > > I don't know what this frontend/backend rework would > > look like for vfio-pci, but it seems non-trivial for this one use case > > and I don't see that it adds

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: > > > * Jens Freimann (jfreim...@redhat.com) wrote: [...] > > > > +} > > > > +if (

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Fri, May 31, 2019 at 04:43:44PM -0400, Michael S. Tsirkin wrote: > On Fri, May 31, 2019 at 07:45:13PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > > Yes. It's just lots of ext

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Michael S. Tsirkin
On Fri, May 31, 2019 at 02:29:33PM -0600, Alex Williamson wrote: > I don't know what this frontend/backend rework would > look like for vfio-pci, but it seems non-trivial for this one use case > and I don't see that it adds any value outside of this use case, > perhaps quite the opposite, it's an o

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Michael S. Tsirkin
On Fri, May 31, 2019 at 07:45:13PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > Yes. It's just lots of extremely low level interfaces > > > > and all rather pointless. > > > > > > >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Alex Williamson
On Fri, 31 May 2019 19:45:13 +0100 "Dr. David Alan Gilbert" wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > > Yes. It's just lots of extremely low level interfaces > > > > and all rather pointless. > > > > > > >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > Yes. It's just lots of extremely low level interfaces > > > and all rather pointless. > > > > > > And down the road extensions like surprise removal support will make it > > > all

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Fri, May 31, 2019 at 02:04:49PM -0400, Michael S. Tsirkin wrote: > On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > > Yes. It's just lots of extremely low level interfaces > > > and all rather pointless. > > > > > > And down the road extensions like surprise removal support

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Michael S. Tsirkin
On Fri, May 31, 2019 at 02:01:54PM -0300, Eduardo Habkost wrote: > > Yes. It's just lots of extremely low level interfaces > > and all rather pointless. > > > > And down the road extensions like surprise removal support will make it > > all cleaner and more transparent. Floating things up to libvi

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Eduardo Habkost
On Thu, May 30, 2019 at 07:06:29PM -0400, Michael S. Tsirkin wrote: > On Thu, May 30, 2019 at 03:22:10PM -0300, Eduardo Habkost wrote: > > On Thu, May 30, 2019 at 02:09:42PM -0400, Michael S. Tsirkin wrote: > > > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > > > * Mich

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-31 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, May 30, 2019 at 08:08:23PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > > > * Michael S. Tsirkin (m...@redhat.com) wrot

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2019 at 03:22:10PM -0300, Eduardo Habkost wrote: > On Thu, May 30, 2019 at 02:09:42PM -0400, Michael S. Tsirkin wrote: > > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Thu, May 30, 2019 at 04:5

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2019 at 08:08:23PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Thu, May 30, 2019 at 04:56:45PM +0200, J

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Dr. David Alan Gilbert
* Jens Freimann (jfreim...@redhat.com) wrote: > Hi David, > > sorry for the delayed reply. > > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: > > > * Jens Freimann (jfreim...@redhat.com) wrote: > > >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > > Hi David, > > > > > > > > sorry for the delayed re

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Eduardo Habkost
On Thu, May 30, 2019 at 02:09:42PM -0400, Michael S. Tsirkin wrote: > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > > Hi David, > > > > > > > > sor

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Eduardo Habkost
On Thu, Dec 06, 2018 at 10:01:46AM +, Daniel P. Berrangé wrote: > Users absolutely *do* care why migration is not finishing. A migration that > does not finish is a major problem for mgmt apps in many case of the use > cases for migration. Especially important when evacuating VMs from a host >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > Hi David, > > > > > > sorry for the delayed reply. > > > > > > On Tue, May 28, 2019 at 11:04:15AM -0400

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > Hi David, > > > > sorry for the delayed reply. > > > > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > Hi David, > > sorry for the delayed reply. > > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: > > > * Jens Freimann (jfreim...@redhat.

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-30 Thread Jens Freimann
Hi David, sorry for the delayed reply. On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: * Jens Freimann (jfreim...@redhat.com) wrote: > +static void virtio_net_primary_plug_timer(void *opaque); > + >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-21 Thread Dr. David Alan Gilbert
* Jens Freimann (jfreim...@redhat.com) wrote: > This patch adds support to handle failover device pairs of a virtio-net > device and a vfio-pci device, where the virtio-net acts as the standby > device and the vfio-pci device as the primary. > > The general idea is that we have a pair of devices,

[Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-05-17 Thread Jens Freimann
This patch adds support to handle failover device pairs of a virtio-net device and a vfio-pci device, where the virtio-net acts as the standby device and the vfio-pci device as the primary. The general idea is that we have a pair of devices, a vfio-pci and a emulated (virtio-net) device. Before mi