Re: [Qemu-devel] [PATCH 3/4] e1000e: Rename "disable_vnet_hdr" property to "vnet"

2016-10-27 Thread Dmitry Fleytman
> On 26 Oct 2016, at 22:21 PM, Eduardo Habkost wrote: > > The original commit that introduced e1000e (6f3fbe4e) mentioned a > property called "vnet". The actual property name added by the > patch is "disable_vnet_hdr". Rename the property so that: > > 1) we avoid confusing double-negatives li

[Qemu-devel] [PATCH 3/4] e1000e: Rename "disable_vnet_hdr" property to "vnet"

2016-10-26 Thread Eduardo Habkost
The original commit that introduced e1000e (6f3fbe4e) mentioned a property called "vnet". The actual property name added by the patch is "disable_vnet_hdr". Rename the property so that: 1) we avoid confusing double-negatives like "disable_vnet_hdr=false"; 2) we avoid underscores in property nam