Re: [Qemu-devel] [PATCH 3/3] w32: Fix format string regression

2011-07-17 Thread Blue Swirl
On Sun, Jul 17, 2011 at 9:34 PM, Stefan Weil wrote: > Am 17.07.2011 11:03, schrieb Blue Swirl: >> >> On Fri, Jul 15, 2011 at 11:42 PM, Andreas Färber >> wrote: >>> >>> Am 15.07.2011 um 21:38 schrieb Stefan Weil: Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8 introduced FMT_pid whi

Re: [Qemu-devel] [PATCH 3/3] w32: Fix format string regression

2011-07-17 Thread Stefan Weil
Am 17.07.2011 11:03, schrieb Blue Swirl: On Fri, Jul 15, 2011 at 11:42 PM, Andreas Färber wrote: Am 15.07.2011 um 21:38 schrieb Stefan Weil: Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8 introduced FMT_pid which is wrong for w32 and w64 getpid(): those getpid() implementations always return

Re: [Qemu-devel] [PATCH 3/3] w32: Fix format string regression

2011-07-17 Thread Blue Swirl
On Fri, Jul 15, 2011 at 11:42 PM, Andreas Färber wrote: > Am 15.07.2011 um 21:38 schrieb Stefan Weil: > >> Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8 >> introduced FMT_pid which is wrong for w32 and w64 getpid(): >> those getpid() implementations always return an int value. This is not in li

Re: [Qemu-devel] [PATCH 3/3] w32: Fix format string regression

2011-07-15 Thread Andreas Färber
Am 15.07.2011 um 21:38 schrieb Stefan Weil: Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8 introduced FMT_pid which is wrong for w32 and w64 getpid(): those getpid() implementations always return an int value. Where is __int64 FMT_pid used then if not for the returned pid? Andreas Signed-

[Qemu-devel] [PATCH 3/3] w32: Fix format string regression

2011-07-15 Thread Stefan Weil
Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8 introduced FMT_pid which is wrong for w32 and w64 getpid(): those getpid() implementations always return an int value. Signed-off-by: Stefan Weil --- os-win32.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/os-win32.c b/