Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl

2016-05-23 Thread Gerd Hoffmann
Hi, > > We could turn the virgl switch into tristate (OnOffAuto), have it > > default to Auto, then fail (not warn) in case it is set to On without 3d > > support being available. > > > > Property settings are part of the migration format, right? Is there an easy > way to change the 'virgl' pr

Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl

2016-05-20 Thread Cole Robinson
On 05/20/2016 01:53 AM, Gerd Hoffmann wrote: > On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote: >> Give users a hint if their config is wrong. >> >> Signed-off-by: Cole Robinson >> --- >> If virgl support is built into qemu, virgl=on is the default, so this >> could be noisy in cases where p

Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl

2016-05-19 Thread Gerd Hoffmann
On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote: > Give users a hint if their config is wrong. > > Signed-off-by: Cole Robinson > --- > If virgl support is built into qemu, virgl=on is the default, so this > could be noisy in cases where people don't even care about virgl. So > I won't obje

Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl

2016-05-19 Thread Marc-André Lureau
Hi On Wed, May 18, 2016 at 6:40 PM, Cole Robinson wrote: > Give users a hint if their config is wrong. > > Signed-off-by: Cole Robinson > --- > If virgl support is built into qemu, virgl=on is the default, so this > could be noisy in cases where people don't even care about virgl. So > I won't o

[Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl

2016-05-18 Thread Cole Robinson
Give users a hint if their config is wrong. Signed-off-by: Cole Robinson --- If virgl support is built into qemu, virgl=on is the default, so this could be noisy in cases where people don't even care about virgl. So I won't object if this is dropped. The message also pops up once via make check,