Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-12 Thread Cornelia Huck
On Tue, 12 Dec 2017 22:05:24 +0800 Dong Jia Shi wrote: > * Dong Jia Shi [2017-12-05 15:43:00 +0800]: > > > * Cornelia Huck [2017-12-04 17:11:24 +0100]: > > > > [...] > > > > This one looks good to me too, so: > > Reviewed-by: Dong Jia Shi > > > > > > > > (...) > > > > > > > > Looks s

Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-12 Thread Dong Jia Shi
* Dong Jia Shi [2017-12-05 15:43:00 +0800]: > * Cornelia Huck [2017-12-04 17:11:24 +0100]: > > [...] > > This one looks good to me too, so: > Reviewed-by: Dong Jia Shi > > > > > (...) > > > > > > Looks sane. We should put a note into the 2.12 changelog as well. > > > > > > > > > > I ag

Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-05 Thread Halil Pasic
On 12/05/2017 08:48 AM, Dong Jia Shi wrote: > * Dong Jia Shi [2017-12-05 15:43:00 +0800]: > >> * Cornelia Huck [2017-12-04 17:11:24 +0100]: >> >> [...] >> >> This one looks good to me too, so: >> Reviewed-by: Dong Jia Shi >> > BTW, since we are deprecating s390-squash-mcss, I think any more >

Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-04 Thread Dong Jia Shi
* Dong Jia Shi [2017-12-05 15:43:00 +0800]: > * Cornelia Huck [2017-12-04 17:11:24 +0100]: > > [...] > > This one looks good to me too, so: > Reviewed-by: Dong Jia Shi > BTW, since we are deprecating s390-squash-mcss, I think any more improment on it (e.g. more accurate and helpful hint mess

Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-04 Thread Dong Jia Shi
* Cornelia Huck [2017-12-04 17:11:24 +0100]: [...] This one looks good to me too, so: Reviewed-by: Dong Jia Shi > > (...) > > > > Looks sane. We should put a note into the 2.12 changelog as well. > > > > > > > I agree. Who would be responsible for updating the changelog. I'm not > > fami

Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-04 Thread Cornelia Huck
On Mon, 4 Dec 2017 16:32:16 +0100 Halil Pasic wrote: > On 12/04/2017 12:28 PM, Cornelia Huck wrote: > > On Fri, 1 Dec 2017 15:31:36 +0100 > > Halil Pasic wrote: > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > >> index 4d65a50334..3796f666e6 100644 > >> --- a/hw/s390

Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-04 Thread Halil Pasic
On 12/04/2017 12:28 PM, Cornelia Huck wrote: > On Fri, 1 Dec 2017 15:31:36 +0100 > Halil Pasic wrote: > >> With the cssids unrestricted (commit "s390x/css: unrestrict > > I won't add the commit id, as I intend to merge this in one go and I > don't want to edit this every time I rebase prior

Re: [Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-04 Thread Cornelia Huck
On Fri, 1 Dec 2017 15:31:36 +0100 Halil Pasic wrote: > With the cssids unrestricted (commit "s390x/css: unrestrict I won't add the commit id, as I intend to merge this in one go and I don't want to edit this every time I rebase prior to pull. > cssids") the s390-squash-mcss machine property s

[Qemu-devel] [PATCH 3/3] s390x: deprecate s390-squash-mcss machine prop

2017-12-01 Thread Halil Pasic
With the cssids unrestricted (commit "s390x/css: unrestrict cssids") the s390-squash-mcss machine property should not be used. Actually libvirt never supported this, so the expectation is that removing it should be pretty painless. But let's play nice and deprecate it first. Signed-off-by: Halil