Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-10 Thread Marcel Apfelbaum
Hi Gerd, On 5/10/19 1:39 PM, Gerd Hoffmann wrote: On Fri, May 10, 2019 at 12:20:56PM +0300, Marcel Apfelbaum wrote: Hi Gerd, On 5/10/19 11:59 AM, Gerd Hoffmann wrote: Hi, Got it, thanks. Is a pity ramfb is not a PCI device :), it was worth the question anyway. If you look for a simple

Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-10 Thread Gerd Hoffmann
On Fri, May 10, 2019 at 12:20:56PM +0300, Marcel Apfelbaum wrote: > Hi Gerd, > > On 5/10/19 11:59 AM, Gerd Hoffmann wrote: > >Hi, > > > > > Got it, thanks. Is a pity ramfb is not a PCI device :), it was worth the > > > question anyway. > > If you look for a simple pci display device check out

Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-10 Thread Marcel Apfelbaum
Hi Gerd, On 5/10/19 11:59 AM, Gerd Hoffmann wrote: Hi, Got it, thanks. Is a pity ramfb is not a PCI device :), it was worth the question anyway. If you look for a simple pci display device check out bochs-display. It's simliar to stdvga (so ovmf and bochs-drm.ko can drive it just fine), bu

Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-10 Thread Gerd Hoffmann
Hi, > Got it, thanks. Is a pity ramfb is not a PCI device :), it was worth the > question anyway. If you look for a simple pci display device check out bochs-display. It's simliar to stdvga (so ovmf and bochs-drm.ko can drive it just fine), but without legacy vga emulation, only a linear frameb

Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-09 Thread Marcel Apfelbaum
On 5/10/19 5:20 AM, Hou Qiming wrote: > Please format the commit subject with a prefix and do not use the same > subject for all the pacthes > in the series, for this patch it can be something like: I'll resend the patches with improved title lines after other issues are cleared. Thanks for

Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-09 Thread Gerd Hoffmann
> --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3080,8 +3080,10 @@ static void vfio_realize(PCIDevice *pdev, Error > **errp) > error_setg(errp, "xres and yres properties require > display=on"); > goto out_teardown; > } > -if (vdev->dpy->edid_regs == NULL

Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-09 Thread Hou Qiming
> Please format the commit subject with a prefix and do not use the same > subject for all the pacthes > in the series, for this patch it can be something like: I'll resend the patches with improved title lines after other issues are cleared. Thanks for the advice. > Will this result in a silent

Re: [Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-09 Thread Marcel Apfelbaum
On 5/9/19 10:58 AM, Hou Qiming wrote: Write an initial resolution to the configuration space on guest reset, which a later BIOS / OVMF patch can take advantage of. I like the idea of moving the ramfb configuration to the PCI configuration space, do you think is possible to move all the ra

[Qemu-devel] [PATCH 3/3] ramfb enhancement

2019-05-09 Thread Hou Qiming
Write an initial resolution to the configuration space on guest reset, which a later BIOS / OVMF patch can take advantage of. Signed-off-by: HOU Qiming --- hw/display/ramfb-standalone.c | 12 +++- hw/display/ramfb.c| 16 +++- hw/vfio/display.c | 4 ++-