Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64)

2016-11-23 Thread Eric Blake
On 11/23/2016 10:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/23/2016 08:17 AM, Markus Armbruster wrote: >> >>> >>> The first two patches are bug fixes, and as such they should be >>> considered for 2.8. >>> >>> This patch doesn't fix anything, and it might conceivably break >>

Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64)

2016-11-23 Thread Markus Armbruster
Eric Blake writes: > On 11/23/2016 08:17 AM, Markus Armbruster wrote: > >> >> The first two patches are bug fixes, and as such they should be >> considered for 2.8. >> >> This patch doesn't fix anything, and it might conceivably break >> something. Too late for 2.8. > > Ah, but it DOES fix che

Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64)

2016-11-23 Thread Eric Blake
On 11/23/2016 08:17 AM, Markus Armbruster wrote: > > The first two patches are bug fixes, and as such they should be > considered for 2.8. > > This patch doesn't fix anything, and it might conceivably break > something. Too late for 2.8. Ah, but it DOES fix check-qjson on Mac OS. As mentioned

Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64)

2016-11-23 Thread Markus Armbruster
Eric Blake writes: > On 11/23/2016 03:25 AM, Paolo Bonzini wrote: >>> The qobject_from_jsonf() function implements a pseudo-printf >>> language for creating a QObject; however, it is hard-coded to >>> only parse a subset of formats understood by printf(). In >>> particular, any use of a 64-bit i

Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64)

2016-11-23 Thread Eric Blake
On 11/23/2016 03:25 AM, Paolo Bonzini wrote: >> The qobject_from_jsonf() function implements a pseudo-printf >> language for creating a QObject; however, it is hard-coded to >> only parse a subset of formats understood by printf(). In >> particular, any use of a 64-bit integer works only if the >>

Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64)

2016-11-23 Thread Paolo Bonzini
> The qobject_from_jsonf() function implements a pseudo-printf > language for creating a QObject; however, it is hard-coded to > only parse a subset of formats understood by printf(). In > particular, any use of a 64-bit integer works only if the > system's definition of PRId64 matches what the pa

[Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64)

2016-11-22 Thread Eric Blake
The qobject_from_jsonf() function implements a pseudo-printf language for creating a QObject; however, it is hard-coded to only parse a subset of formats understood by printf(). In particular, any use of a 64-bit integer works only if the system's definition of PRId64 matches what the parser expec