Hi Philippe,
> > I don't mind much, but why? My reasoning was "let's first fix the cause
> > and then the symptom"?
>
> The '0' case is worst than incorrect, it segfaults, so you are right :)
Ok, thanks.
> >> Can you add a #define for this value? Such AT24C_ROMSIZE_MIN.
> >
> > Can do, of cour
Hi Wolfram,
On 03/13/2018 09:16 PM, Wolfram Sang wrote:
> Hi Philippe,
>
>>> static Property at24c_eeprom_props[] = {
>>> -DEFINE_PROP_UINT32("rom-size", EEPROMState, rsize, 0),
>>> +DEFINE_PROP_UINT32("rom-size", EEPROMState, rsize, 128),
>>
>> This patch should goes before your 2/3 in
Hi Philippe,
> > static Property at24c_eeprom_props[] = {
> > -DEFINE_PROP_UINT32("rom-size", EEPROMState, rsize, 0),
> > +DEFINE_PROP_UINT32("rom-size", EEPROMState, rsize, 128),
>
> This patch should goes before your 2/3 in your series.
I don't mind much, but why? My reasoning was "le
Hi Wolfram,
On 03/12/2018 10:42 PM, Wolfram Sang wrote:
> 0 as "rom-size" doesn't make much sense, let's use the smallest 24cXX
> which has 128 byte.
>
> Signed-off-by: Wolfram Sang
> ---
> hw/nvram/eeprom_at24c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nvra
0 as "rom-size" doesn't make much sense, let's use the smallest 24cXX
which has 128 byte.
Signed-off-by: Wolfram Sang
---
hw/nvram/eeprom_at24c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
index d82710e1df..de988f8d07 100
