Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-21 Thread Alon Levy
On Wed, Oct 20, 2010 at 02:24:20PM -0200, Luiz Capitulino wrote: > On Tue, 19 Oct 2010 15:35:01 +0200 > Gerd Hoffmann wrote: > > >Hi, > > > > > +.help = "attach USB device 'bus.addr'", > > > > > +...@item usb_attach @var{devname} > > > > /me sees a mismatch here. > > > > The

Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-21 Thread Alon Levy
On Thu, Oct 21, 2010 at 12:00:12PM +0200, Gerd Hoffmann wrote: > On 10/20/10 18:24, Luiz Capitulino wrote: > >On Tue, 19 Oct 2010 15:35:01 +0200 > >Gerd Hoffmann wrote: > > > >>Hi, > >> > >>>+.help = "attach USB device 'bus.addr'", > >> > >>>+...@item usb_attach @var{devname} > >

Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-21 Thread Gerd Hoffmann
On 10/20/10 18:24, Luiz Capitulino wrote: On Tue, 19 Oct 2010 15:35:01 +0200 Gerd Hoffmann wrote: Hi, +.help = "attach USB device 'bus.addr'", +...@item usb_attach @var{devname} /me sees a mismatch here. There is still the use case question. Also note that this might

[Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach (v2)

2010-10-20 Thread Alon Levy
v1->v2 changes: * fixed help text (consistent name for parameter) * added configure flag, also enabled with --enable-debug --- configure |9 + hmp-commands.hx | 38 ++ sysemu.h|4 vl.c| 33

Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-20 Thread Luiz Capitulino
On Tue, 19 Oct 2010 15:35:01 +0200 Gerd Hoffmann wrote: >Hi, > > > +.help = "attach USB device 'bus.addr'", > > > +...@item usb_attach @var{devname} > > /me sees a mismatch here. > > There is still the use case question. Also note that this might have > unwanted side effec

Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-19 Thread Gerd Hoffmann
Hi, +.help = "attach USB device 'bus.addr'", +...@item usb_attach @var{devname} /me sees a mismatch here. There is still the use case question. Also note that this might have unwanted side effects when drivers automagically attach/detach devices like usb-host. Having t

[Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

2010-10-19 Thread Alon Levy
--- hmp-commands.hx | 34 ++ sysemu.h|2 ++ vl.c| 31 +++ 3 files changed, 67 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 81999aa..660205c 100644 --- a/hmp-commands.hx ++