On Wed, Mar 27, 2013 at 08:29:41PM +0100, Hans de Goede wrote:
> Signed-off-by: Hans de Goede
> Cc: Alberto Garcia
Sorry for the delay, just came back from holidays :)
I've just tested it and the change looks fine to me.
Signed-off-by: Alberto Garcia
Berto
Hi,
On 03/28/2013 07:18 AM, Paolo Bonzini wrote:
Signed-off-by: Hans de Goede
Cc: Alberto Garcia
I don't think this is a show stopper, but this is a compatibility
breaker, no?
We should be more up front about that and include release notes as
appropriate.
Yes on all counts. I can work
> Given that you requested this change, it indeed probably is best if
> you did this :) Feel free to squash this into the patch if that is
> preferred (and to make yourself the author of the patch in that
> case).
>
> So how are we going to go about upstreaming these? Anthony will you
> pick 1 +
> > Signed-off-by: Hans de Goede
> > Cc: Alberto Garcia
>
> I don't think this is a show stopper, but this is a compatibility
> breaker, no?
>
> We should be more up front about that and include release notes as
> appropriate.
Yes on all counts. I can work on the release notes.
Paolo
Hans de Goede writes:
> Signed-off-by: Hans de Goede
> Cc: Alberto Garcia
I don't think this is a show stopper, but this is a compatibility
breaker, no?
We should be more up front about that and include release notes as
appropriate.
Signed-off-by: Anthony Liguori
> ---
> hw/ipoctal232.c |
Signed-off-by: Hans de Goede
Cc: Alberto Garcia
---
hw/ipoctal232.c | 43 ++-
1 file changed, 14 insertions(+), 29 deletions(-)
diff --git a/hw/ipoctal232.c b/hw/ipoctal232.c
index 345efae..685fee2 100644
--- a/hw/ipoctal232.c
+++ b/hw/ipoctal232.c
@@ -93
