Re: [Qemu-devel] [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-12 Thread Avi Kivity
On 09/12/2010 05:29 PM, Anthony Liguori wrote: On 09/12/2010 08:26 AM, Avi Kivity wrote: On 09/12/2010 03:08 PM, Anthony Liguori wrote: This can cause a disk read, no? Shouldn't it be made asynchronous? Yes, it should. I'm not sure there's an easy way to make it asynchronous though not

Re: [Qemu-devel] [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-12 Thread Anthony Liguori
On 09/12/2010 08:26 AM, Avi Kivity wrote: On 09/12/2010 03:08 PM, Anthony Liguori wrote: This can cause a disk read, no? Shouldn't it be made asynchronous? Yes, it should. I'm not sure there's an easy way to make it asynchronous though not because of the block layer but because of how th

Re: [Qemu-devel] [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-12 Thread Avi Kivity
On 09/12/2010 03:08 PM, Anthony Liguori wrote: This can cause a disk read, no? Shouldn't it be made asynchronous? Yes, it should. I'm not sure there's an easy way to make it asynchronous though not because of the block layer but because of how these functions are called. Sorry to harp o

Re: [Qemu-devel] [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-12 Thread Anthony Liguori
On 09/12/2010 05:42 AM, Avi Kivity wrote: On 09/11/2010 05:04 PM, Anthony Liguori wrote: This fixes a couple nasty problems relating to live migration. 1) When dealing with shared storage with weak coherence (i.e. NFS), even if we re-read, we may end up with undesired caching. By delayin

Re: [Qemu-devel] [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-12 Thread Avi Kivity
On 09/11/2010 05:04 PM, Anthony Liguori wrote: This fixes a couple nasty problems relating to live migration. 1) When dealing with shared storage with weak coherence (i.e. NFS), even if we re-read, we may end up with undesired caching. By delaying any reads until we absolutely have to,

Re: [Qemu-devel] [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-11 Thread Anthony Liguori
On 09/11/2010 12:24 PM, Stefan Hajnoczi wrote: On Sat, Sep 11, 2010 at 3:04 PM, Anthony Liguori wrote: This fixes a couple nasty problems relating to live migration. 1) When dealing with shared storage with weak coherence (i.e. NFS), even if we re-read, we may end up with undesired cach

Re: [Qemu-devel] [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-11 Thread Stefan Hajnoczi
On Sat, Sep 11, 2010 at 3:04 PM, Anthony Liguori wrote: > This fixes a couple nasty problems relating to live migration. > > 1) When dealing with shared storage with weak coherence (i.e. NFS), even if >   we re-read, we may end up with undesired caching.  By delaying any reads >   until we absolut

[Qemu-devel] [PATCH 3/3] disk: don't read from disk until the guest starts

2010-09-11 Thread Anthony Liguori
This fixes a couple nasty problems relating to live migration. 1) When dealing with shared storage with weak coherence (i.e. NFS), even if we re-read, we may end up with undesired caching. By delaying any reads until we absolutely have to, we decrease the likelihood of any undesirable ca