Re: [Qemu-devel] [PATCH 3/3] arm_mptimer: Respect IT bit state

2015-07-04 Thread Dmitry Osipenko
Hello Peter, 04.07.2015 22:39, Peter Crosthwaite пишет: You also need to trigger timerblock_update_irq on change of state for the control bit itself. "case 8: /* Control. */" in the _write handler needs to call this fn. Right, as it will mask/unmask interrupt line. Good catch, thanks. -- D

Re: [Qemu-devel] [PATCH 3/3] arm_mptimer: Respect IT bit state

2015-07-04 Thread Peter Crosthwaite
On Thu, Jul 2, 2015 at 3:52 PM, Dmitry Osipenko wrote: > Timer fires interrupt regardless of current IT(interrupt enable) bit state. > Fix it by making timer to respect IT state. > > Signed-off-by: Dmitry Osipenko > --- > hw/timer/arm_mptimer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

[Qemu-devel] [PATCH 3/3] arm_mptimer: Respect IT bit state

2015-07-02 Thread Dmitry Osipenko
Timer fires interrupt regardless of current IT(interrupt enable) bit state. Fix it by making timer to respect IT state. Signed-off-by: Dmitry Osipenko --- hw/timer/arm_mptimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/arm_mptimer.c b/hw/timer/arm_mptimer.c in