On 05/31/2011 08:35 AM, Luiz Capitulino wrote:
On Tue, 31 May 2011 10:12:17 +0200
Do we break anything if we make eject really eject the medium (we have a
virtual tray status now) instead of just closing the image?
I don't think so. I guess users/clients really have the expectation that
the on
On Tue, 31 May 2011 10:12:17 +0200
Kevin Wolf wrote:
> Am 30.05.2011 16:49, schrieb Markus Armbruster:
> > Luiz Capitulino writes:
> >
> >> On Sat, 28 May 2011 09:58:24 +0200
> >> Markus Armbruster wrote:
> >>
> >>> Luiz Capitulino writes:
> diff --git a/block.h b/block.h
> index 1f
Am 30.05.2011 16:49, schrieb Markus Armbruster:
> Luiz Capitulino writes:
>
>> On Sat, 28 May 2011 09:58:24 +0200
>> Markus Armbruster wrote:
>>
>>> Luiz Capitulino writes:
diff --git a/block.h b/block.h
index 1f58eab..e4053dd 100644
--- a/block.h
+++ b/block.h
@@ -50,6
Luiz Capitulino writes:
> On Sat, 28 May 2011 09:58:24 +0200
> Markus Armbruster wrote:
>
>> Luiz Capitulino writes:
>>
>> > Conforms to the event specification defined in the
>> > QMP/qmp-events.txt file.
>>
>> I'd squash PATCH 2+3.
>
> I agree this would be more logical, but people have com
On Sat, 28 May 2011 09:58:24 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > Conforms to the event specification defined in the
> > QMP/qmp-events.txt file.
>
> I'd squash PATCH 2+3.
I agree this would be more logical, but people have complained that it's hard
to review new com
Luiz Capitulino writes:
> Conforms to the event specification defined in the
> QMP/qmp-events.txt file.
I'd squash PATCH 2+3.
>
> Please, note the following details:
>
> o The event should be emitted only by devices which support the
>eject operation, which currently are: CDROMs (IDE and S
Conforms to the event specification defined in the
QMP/qmp-events.txt file.
Please, note the following details:
o The event should be emitted only by devices which support the
eject operation, which currently are: CDROMs (IDE and SCSI)
and floppies
o Human monitor commands "eject" and "c
Conforms to the event specification defined in the
QMP/qmp-events.txt file.
Please, note the following (very important) details:
o The event should be emitted only by devices which support the
eject operation, which (afaik) are: CDROMs (IDE and SCSI) and
floppies
o Human monitor commands
