Re: [Qemu-devel] [PATCH 26/32] ppc: Speed up dcbz

2016-07-26 Thread Benjamin Herrenschmidt
On Wed, 2016-07-27 at 12:36 +1000, David Gibson wrote: > > -    do_dcbz(env, addr, dcbz_size, GETPC()); > > +    /* Try fast path translate */ > > +    haddr = tlb_vaddr_to_host(env, addr, MMU_DATA_STORE, env->dmmu_idx); > > It worries me slightly that this doesn't take any length to verify.  I >

Re: [Qemu-devel] [PATCH 26/32] ppc: Speed up dcbz

2016-07-26 Thread David Gibson
On Wed, Jul 27, 2016 at 08:21:20AM +1000, Benjamin Herrenschmidt wrote: > Use tlb_vaddr_to_host to do a fast path single translate for > the whole cache line. Also make the reservation check match > the entire range. > > Signed-off-by: Benjamin Herrenschmidt > --- > target-ppc/mem_helper.c | 46

[Qemu-devel] [PATCH 26/32] ppc: Speed up dcbz

2016-07-26 Thread Benjamin Herrenschmidt
Use tlb_vaddr_to_host to do a fast path single translate for the whole cache line. Also make the reservation check match the entire range. Signed-off-by: Benjamin Herrenschmidt --- target-ppc/mem_helper.c | 46 +- target-ppc/translate.c | 11 -