Re: [Qemu-devel] [PATCH 23/42] migration: yay, buffering is gone

2013-03-05 Thread Paolo Bonzini
> Hi, Paolo > Do you think static buffer in qemu_file should be also removed? Orit is working on that. Paolo

Re: [Qemu-devel] [PATCH 23/42] migration: yay, buffering is gone

2013-03-05 Thread Wenchao Xia
Hi, Paolo Do you think static buffer in qemu_file should be also removed? > Buffering was needed because blocking writes could take a long time > and starve other threads seeking to grab the big QEMU mutex. > > Now that all writes (except within _complete callbacks) are done > outside the big Q

[Qemu-devel] [PATCH 23/42] migration: yay, buffering is gone

2013-02-22 Thread Paolo Bonzini
Buffering was needed because blocking writes could take a long time and starve other threads seeking to grab the big QEMU mutex. Now that all writes (except within _complete callbacks) are done outside the big QEMU mutex, we do not need buffering at all. Reviewed-by: Orit Wasserman Reviewed-by: