Re: [Qemu-devel] [PATCH 23/38] shpc: split shpc_free from shpc_cleanup

2013-09-17 Thread Michael S. Tsirkin
On Tue, Sep 17, 2013 at 11:58:12AM +0200, Paolo Bonzini wrote: > Il 17/09/2013 11:24, Michael S. Tsirkin ha scritto: > >> @@ -630,15 +630,21 @@ int shpc_bar_size(PCIDevice *d) > >> void shpc_cleanup(PCIDevice *d, MemoryRegion *bar) > >> { > >> SHPCDevice *shpc = d->shpc; > >> +/* TODO: c

Re: [Qemu-devel] [PATCH 23/38] shpc: split shpc_free from shpc_cleanup

2013-09-17 Thread Paolo Bonzini
Il 17/09/2013 11:24, Michael S. Tsirkin ha scritto: >> @@ -630,15 +630,21 @@ int shpc_bar_size(PCIDevice *d) >> void shpc_cleanup(PCIDevice *d, MemoryRegion *bar) >> { >> SHPCDevice *shpc = d->shpc; >> +/* TODO: cleanup config space changes? */ >> d->cap_present &= ~QEMU_PCI_CAP_SHP

Re: [Qemu-devel] [PATCH 23/38] shpc: split shpc_free from shpc_cleanup

2013-09-17 Thread Michael S. Tsirkin
On Tue, Sep 03, 2013 at 02:33:14PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/pci-bridge/pci_bridge_dev.c | 2 ++ > hw/pci/shpc.c | 8 +++- > include/hw/pci/shpc.h | 1 + > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/

[Qemu-devel] [PATCH 23/38] shpc: split shpc_free from shpc_cleanup

2013-09-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pci-bridge/pci_bridge_dev.c | 2 ++ hw/pci/shpc.c | 8 +++- include/hw/pci/shpc.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index a9392c7..