Re: [Qemu-devel] [PATCH 23/27] vhost-user-scsi: use glib logging

2017-08-23 Thread Philippe Mathieu-Daudé
On 08/23/2017 01:20 PM, Marc-André Lureau wrote: - PLOG is unused - code is compiled out unless debug is enabled - logging is too verbose - you can pipe to ts to have timestamp if needed, or use structured logging with more recent glib Signed-off-by: Marc-André Lureau Reviewed-by: Philippe

[Qemu-devel] [PATCH 23/27] vhost-user-scsi: use glib logging

2017-08-23 Thread Marc-André Lureau
- PLOG is unused - code is compiled out unless debug is enabled - logging is too verbose - you can pipe to ts to have timestamp if needed, or use structured logging with more recent glib Signed-off-by: Marc-André Lureau --- contrib/vhost-user-scsi/vhost-user-scsi.c | 77 +--