Re: [Qemu-devel] [PATCH 23/25] block: add close notifiers

2012-10-19 Thread Paolo Bonzini
> > @@ -1098,12 +1106,13 @@ void bdrv_reopen_abort(BDRVReopenState > > *reopen_state) > > void bdrv_close(BlockDriverState *bs) > > { > > bdrv_flush(bs); > > -if (bs->drv) { > > -if (bs->job) { > > -block_job_cancel_sync(bs->job); > > -} > > -bdrv_dra

Re: [Qemu-devel] [PATCH 23/25] block: add close notifiers

2012-10-19 Thread Markus Armbruster
Paolo Bonzini writes: > The first user of close notifiers will be the embedded NBD server. > It is possible to use them to do some of the ad hoc processing > (e.g. for block jobs and I/O limits) that is currently done by > bdrv_close. If the second sentence is an idea for future work, you could

Re: [Qemu-devel] [PATCH 23/25] block: add close notifiers

2012-10-19 Thread Markus Armbruster
Paolo Bonzini writes: > The first user of close notifiers will be the embedded NBD server. > It is possible to use them to do some of the ad hoc processing > (e.g. for block jobs and I/O limits) that is currently done by > bdrv_close. > > Acked-by: Kevin Wolf > Signed-off-by: Paolo Bonzini > --

[Qemu-devel] [PATCH 23/25] block: add close notifiers

2012-10-10 Thread Paolo Bonzini
The first user of close notifiers will be the embedded NBD server. It is possible to use them to do some of the ad hoc processing (e.g. for block jobs and I/O limits) that is currently done by bdrv_close. Acked-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- Makefile.objs | 4 ++-- block.c