Re: [Qemu-devel] [PATCH 21/47] block: add bdrv_ensure_backing_file

2012-09-11 Thread Kevin Wolf
Am 11.09.2012 16:10, schrieb Paolo Bonzini: > > > - Messaggio originale - >> Da: "Kevin Wolf" >> A: "Paolo Bonzini" >> Cc: qemu-devel@nongnu.org, ebl...@redhat.com, jc...@redhat.com, >> stefa...@linux.vnet.ibm.com >> Inviato: Martedì, 11 settembre 2012 15:58:38 >> Oggetto: Re: [PATCH 2

Re: [Qemu-devel] [PATCH 21/47] block: add bdrv_ensure_backing_file

2012-09-11 Thread Paolo Bonzini
- Messaggio originale - > Da: "Kevin Wolf" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, ebl...@redhat.com, jc...@redhat.com, > stefa...@linux.vnet.ibm.com > Inviato: Martedì, 11 settembre 2012 15:58:38 > Oggetto: Re: [PATCH 21/47] block: add bdrv_ensure_backing_file > > Am 11.09.

Re: [Qemu-devel] [PATCH 21/47] block: add bdrv_ensure_backing_file

2012-09-11 Thread Kevin Wolf
Am 11.09.2012 15:46, schrieb Paolo Bonzini: > >> Once again, combining code motion and code changes in one patch makes >> it harder to review. > > bdrv_ensure_backing_file() is a new standalone function that happens to be > usable in bdrv_open as well. But I can separate the changes/fixes to a >

Re: [Qemu-devel] [PATCH 21/47] block: add bdrv_ensure_backing_file

2012-09-11 Thread Paolo Bonzini
> Once again, combining code motion and code changes in one patch makes > it harder to review. bdrv_ensure_backing_file() is a new standalone function that happens to be usable in bdrv_open as well. But I can separate the changes/fixes to a separate patch. In particular it is can be used after

Re: [Qemu-devel] [PATCH 21/47] block: add bdrv_ensure_backing_file

2012-09-11 Thread Kevin Wolf
Am 24.07.2012 13:03, schrieb Paolo Bonzini: > Mirroring runs without the backing file so that it can be copied outside > QEMU. However, we need to add it at the time the job is completed and > QEMU switches to the target. Factor out the common bits of opening an > image and completing a mirroring

[Qemu-devel] [PATCH 21/47] block: add bdrv_ensure_backing_file

2012-07-24 Thread Paolo Bonzini
Mirroring runs without the backing file so that it can be copied outside QEMU. However, we need to add it at the time the job is completed and QEMU switches to the target. Factor out the common bits of opening an image and completing a mirroring operation. Signed-off-by: Paolo Bonzini --- bloc