Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-26 Thread Igor Mammedov
On Mon, 25 Nov 2013 18:00:56 +0100 Andreas Färber wrote: > Am 25.11.2013 11:41, schrieb Igor Mammedov: > > On Thu, 21 Nov 2013 17:09:27 +0100 > > Andreas Färber wrote: > > > >> Am 21.11.2013 15:34, schrieb Igor Mammedov: > >>> On Thu, 21 Nov 2013 15:13:12 +0100 > >>> Andreas Färber wrote: > >>

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Andreas Färber
Am 25.11.2013 11:41, schrieb Igor Mammedov: > On Thu, 21 Nov 2013 17:09:27 +0100 > Andreas Färber wrote: > >> Am 21.11.2013 15:34, schrieb Igor Mammedov: >>> On Thu, 21 Nov 2013 15:13:12 +0100 >>> Andreas Färber wrote: Am 21.11.2013 06:48, schrieb Li Guang: > Why not give the memory tha

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2013 14:35:18 +0100 Paolo Bonzini wrote: > Il 25/11/2013 12:39, Gerd Hoffmann ha scritto: > >> > As use case 32-bit guest could start whit small initial memory > >> > and hotplug additional memory if needed up to point where 32-bit > >> > PCI hole starts. That would allow guests to

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 12:39, Gerd Hoffmann ha scritto: >> > As use case 32-bit guest could start whit small initial memory >> > and hotplug additional memory if needed up to point where 32-bit >> > PCI hole starts. That would allow guests to launch with small amount >> > but baloon up upto 2-3.5 Gb dependi

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2013 12:39:05 +0100 Gerd Hoffmann wrote: > > > Does it make sense to hotplug memory above 4g unconditionally to > > > simplify things? > > It does and it was so in v6 RFC, > > But it would rule out hotplug for 32-bit guests that doesn't support > > more then 4Gb. > > Indeed. > >

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Gerd Hoffmann
> > Does it make sense to hotplug memory above 4g unconditionally to > > simplify things? > It does and it was so in v6 RFC, > But it would rule out hotplug for 32-bit guests that doesn't support > more then 4Gb. Indeed. > As use case 32-bit guest could start whit small initial memory > and hotpl

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Igor Mammedov
On Fri, 22 Nov 2013 15:23:56 +0100 Gerd Hoffmann wrote: > On Do, 2013-11-21 at 03:38 +0100, Igor Mammedov wrote: > > Add DimmBus for memory hotplug below 4Gb or above 4Gb depending > > on initial memory size and hotplug memory size. > > > > * if ram_size is less than 32-bit PCI hole start, reser

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Igor Mammedov
On Thu, 21 Nov 2013 17:09:27 +0100 Andreas Färber wrote: > Am 21.11.2013 15:34, schrieb Igor Mammedov: > > On Thu, 21 Nov 2013 15:13:12 +0100 > > Andreas Färber wrote: > >> Am 21.11.2013 06:48, schrieb Li Guang: > >>> Why not give the memory that not be hot-added a chance to be placed on > >>> o

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-22 Thread Gerd Hoffmann
On Do, 2013-11-21 at 03:38 +0100, Igor Mammedov wrote: > Add DimmBus for memory hotplug below 4Gb or above 4Gb depending > on initial memory size and hotplug memory size. > > * if ram_size is less than 32-bit PCI hole start, reserve > hotplug memory region as [ram_size,32bit-PCIhole-start) > i

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-21 Thread Igor Mammedov
On Thu, 21 Nov 2013 15:13:12 +0100 Andreas Färber wrote: > Am 21.11.2013 06:48, schrieb Li Guang: > > Hi, Igor > > > > Igor Mammedov wrote: > >> Add DimmBus for memory hotplug below 4Gb or above 4Gb depending > >> on initial memory size and hotplug memory size. > >> > > ... > >> +static > >>

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:34:53PM +0100, Igor Mammedov wrote: > On Thu, 21 Nov 2013 15:13:12 +0100 > Andreas Färber wrote: > > > Am 21.11.2013 06:48, schrieb Li Guang: > > > Hi, Igor > > > > > > Igor Mammedov wrote: > > >> Add DimmBus for memory hotplug below 4Gb or above 4Gb depending > > >> o

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 05:09:27PM +0100, Andreas Färber wrote: > Am 21.11.2013 15:34, schrieb Igor Mammedov: > > On Thu, 21 Nov 2013 15:13:12 +0100 > > Andreas Färber wrote: > >> Am 21.11.2013 06:48, schrieb Li Guang: > >>> Why not give the memory that not be hot-added a chance to be placed on >

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-21 Thread Andreas Färber
Am 21.11.2013 15:34, schrieb Igor Mammedov: > On Thu, 21 Nov 2013 15:13:12 +0100 > Andreas Färber wrote: >> Am 21.11.2013 06:48, schrieb Li Guang: >>> Why not give the memory that not be hot-added a chance to be placed on >>> one memory slot? >> >> Seconded, I believe I requested that on the previ

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-21 Thread Andreas Färber
Am 21.11.2013 06:48, schrieb Li Guang: > Hi, Igor > > Igor Mammedov wrote: >> Add DimmBus for memory hotplug below 4Gb or above 4Gb depending >> on initial memory size and hotplug memory size. >> > ... >> +static >> +void pc_hotplug_memory_init_impl(Object *owner, >> +

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-20 Thread Li Guang
Hi, Igor Igor Mammedov wrote: Add DimmBus for memory hotplug below 4Gb or above 4Gb depending on initial memory size and hotplug memory size. ... +static +void pc_hotplug_memory_init_impl(Object *owner, + MemoryRegion *system_memory, +

[Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-20 Thread Igor Mammedov
Add DimmBus for memory hotplug below 4Gb or above 4Gb depending on initial memory size and hotplug memory size. * if ram_size is less than 32-bit PCI hole start, reserve hotplug memory region as [ram_size,32bit-PCIhole-start) if hotplug memory region fits there, otherwise reserve hotplug mem