Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-19 Thread Eduardo Habkost
On Fri, Jan 19, 2018 at 02:39:49PM +0100, Igor Mammedov wrote: > On Fri, 19 Jan 2018 11:14:30 -0200 > Eduardo Habkost wrote: > > > On Fri, Jan 19, 2018 at 11:14:39AM +0100, Igor Mammedov wrote: > > > On Thu, 18 Jan 2018 17:18:09 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Thu, Jan 18, 2

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-19 Thread Igor Mammedov
On Fri, 19 Jan 2018 11:14:30 -0200 Eduardo Habkost wrote: > On Fri, Jan 19, 2018 at 11:14:39AM +0100, Igor Mammedov wrote: > > On Thu, 18 Jan 2018 17:18:09 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Jan 18, 2018 at 11:10:35AM +0100, Igor Mammedov wrote: > > > > On Wed, 17 Jan 2018 23:48

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-19 Thread Eduardo Habkost
On Fri, Jan 19, 2018 at 11:14:39AM +0100, Igor Mammedov wrote: > On Thu, 18 Jan 2018 17:18:09 -0200 > Eduardo Habkost wrote: > > > On Thu, Jan 18, 2018 at 11:10:35AM +0100, Igor Mammedov wrote: > > > On Wed, 17 Jan 2018 23:48:46 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Wed, Jan 17,

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-19 Thread Igor Mammedov
On Thu, 18 Jan 2018 17:18:09 -0200 Eduardo Habkost wrote: > On Thu, Jan 18, 2018 at 11:10:35AM +0100, Igor Mammedov wrote: > > On Wed, 17 Jan 2018 23:48:46 -0200 > > Eduardo Habkost wrote: > > > > > On Wed, Jan 17, 2018 at 04:43:32PM +0100, Igor Mammedov wrote: > > > > The last user of it w

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-18 Thread Eduardo Habkost
On Thu, Jan 18, 2018 at 11:10:35AM +0100, Igor Mammedov wrote: > On Wed, 17 Jan 2018 23:48:46 -0200 > Eduardo Habkost wrote: > > > On Wed, Jan 17, 2018 at 04:43:32PM +0100, Igor Mammedov wrote: > > > The last user of it was machine type 'none', which used field > > > to create CPU id user request

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-18 Thread Igor Mammedov
On Wed, 17 Jan 2018 23:48:46 -0200 Eduardo Habkost wrote: > On Wed, Jan 17, 2018 at 04:43:32PM +0100, Igor Mammedov wrote: > > The last user of it was machine type 'none', which used field > > to create CPU id user requested it on CLI with -cpu option. > > > > We could compare pointers of Machin

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-17 Thread Eduardo Habkost
On Wed, Jan 17, 2018 at 04:43:32PM +0100, Igor Mammedov wrote: > The last user of it was machine type 'none', which used field > to create CPU id user requested it on CLI with -cpu option. > > We could compare pointers of MachineState::cpu_type and > MachineClass::default_cpu_type to check for the

[Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-17 Thread Igor Mammedov
The last user of it was machine type 'none', which used field to create CPU id user requested it on CLI with -cpu option. We could compare pointers of MachineState::cpu_type and MachineClass::default_cpu_type to check for the same condition, and drop cpu_model concept completly from machine/boards