Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-10 Thread Denis V. Lunev
On 11/10/2015 12:05 AM, Eric Blake wrote: On 11/06/2015 02:13 PM, Denis V. Lunev wrote: That is a case of using libvirt to trigger internal snapshots... The HMP monitor is legacy and also not used by modern libvirt. ...and libvirt is forced to use HMP for internal snapshots, since we _still_

Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-09 Thread Eric Blake
On 11/06/2015 02:13 PM, Denis V. Lunev wrote: >> That is a case of using libvirt to trigger internal snapshots... >> >>> The HMP monitor is legacy and also not used by modern libvirt. >> ...and libvirt is forced to use HMP for internal snapshots, since we >> _still_ haven't exposed internal snapsh

Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-06 Thread Denis V. Lunev
On 11/06/2015 07:05 PM, Eric Blake wrote: On 11/06/2015 08:54 AM, Stefan Hajnoczi wrote: On Wed, Nov 04, 2015 at 08:19:31PM +0300, Denis V. Lunev wrote: with test while /bin/true ; do virsh snapshot-create rhel7 sleep 10 virsh snapshot-delete rhel7 --current

Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-06 Thread Stefan Hajnoczi
On Fri, Nov 6, 2015 at 4:19 PM, Denis V. Lunev wrote: > On 11/06/2015 07:05 PM, Eric Blake wrote: >> >> On 11/06/2015 08:54 AM, Stefan Hajnoczi wrote: >>> >>> On Wed, Nov 04, 2015 at 08:19:31PM +0300, Denis V. Lunev wrote: with test while /bin/true ; do virsh snap

Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-06 Thread Denis V. Lunev
On 11/06/2015 07:05 PM, Eric Blake wrote: On 11/06/2015 08:54 AM, Stefan Hajnoczi wrote: On Wed, Nov 04, 2015 at 08:19:31PM +0300, Denis V. Lunev wrote: with test while /bin/true ; do virsh snapshot-create rhel7 sleep 10 virsh snapshot-delete rhel7 --current

Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-06 Thread Eric Blake
On 11/06/2015 08:54 AM, Stefan Hajnoczi wrote: > On Wed, Nov 04, 2015 at 08:19:31PM +0300, Denis V. Lunev wrote: >> with test >> while /bin/true ; do >> virsh snapshot-create rhel7 >> sleep 10 >> virsh snapshot-delete rhel7 --current >> done >> with enabled iothreads

Re: [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-06 Thread Stefan Hajnoczi
On Wed, Nov 04, 2015 at 08:19:31PM +0300, Denis V. Lunev wrote: > with test > while /bin/true ; do > virsh snapshot-create rhel7 > sleep 10 > virsh snapshot-delete rhel7 --current > done > with enabled iothreads on a running VM leads to a lot of troubles: hangs, > as

[Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes

2015-11-04 Thread Denis V. Lunev
with test while /bin/true ; do virsh snapshot-create rhel7 sleep 10 virsh snapshot-delete rhel7 --current done with enabled iothreads on a running VM leads to a lot of troubles: hangs, asserts, errors. Anyway, I think that the construction like assert(aio_contex