Re: [Qemu-devel] [PATCH 2/9] target-ppc: Fix xscmpodp and xscmpudp instructions

2016-11-23 Thread David Gibson
On Wed, Nov 23, 2016 at 11:10:08AM +0530, Bharata B Rao wrote: > On Wed, Nov 23, 2016 at 03:01:18PM +1100, David Gibson wrote: > > On Tue, Nov 22, 2016 at 05:15:58PM +0530, Nikunj A Dadhania wrote: > > > From: Bharata B Rao > > > > > > - xscmpodp & xscmpudp are missing flags reset. > > > - In xsc

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Fix xscmpodp and xscmpudp instructions

2016-11-22 Thread Bharata B Rao
On Wed, Nov 23, 2016 at 03:01:18PM +1100, David Gibson wrote: > On Tue, Nov 22, 2016 at 05:15:58PM +0530, Nikunj A Dadhania wrote: > > From: Bharata B Rao > > > > - xscmpodp & xscmpudp are missing flags reset. > > - In xscmpodp, VXCC should be set only if VE is 0 for signalling NaN case > > and

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Fix xscmpodp and xscmpudp instructions

2016-11-22 Thread David Gibson
On Tue, Nov 22, 2016 at 05:15:58PM +0530, Nikunj A Dadhania wrote: > From: Bharata B Rao > > - xscmpodp & xscmpudp are missing flags reset. > - In xscmpodp, VXCC should be set only if VE is 0 for signalling NaN case > and VXCC should be set by explicitly checking for quiet NaN case. > - Compari

[Qemu-devel] [PATCH 2/9] target-ppc: Fix xscmpodp and xscmpudp instructions

2016-11-22 Thread Nikunj A Dadhania
From: Bharata B Rao - xscmpodp & xscmpudp are missing flags reset. - In xscmpodp, VXCC should be set only if VE is 0 for signalling NaN case and VXCC should be set by explicitly checking for quiet NaN case. - Comparison is being done only if the operands are not NaNs. However as per ISA, it s