Re: [Qemu-devel] [PATCH 2/9] qapi: Add optional field "name" to block dirty bitmap

2014-01-17 Thread Stefan Hajnoczi
On Mon, Jan 13, 2014 at 06:39:41PM +0800, Fam Zheng wrote: > diff --git a/block.c b/block.c > index 6ad0368..16ef61b 100644 > --- a/block.c > +++ b/block.c > @@ -52,6 +52,7 @@ > struct BdrvDirtyBitmap { > HBitmap *bitmap; > int refcnt; > +char name[1024]; Is there a reason for a fix

[Qemu-devel] [PATCH 2/9] qapi: Add optional field "name" to block dirty bitmap

2014-01-13 Thread Fam Zheng
This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented bdrv_find_dirty_bi