Re: [Qemu-devel] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function

2019-03-03 Thread David Gibson
On Sun, Mar 03, 2019 at 05:23:37PM +, Mark Cave-Ayland wrote: > Instead of having multiple copies of the offset calculation logic, move it to > a > single vsrl_offset() function. > > This commit also renames the existing get_vsr()/set_vsr() functions to > get_vsrl()/set_vsrl() which better de

Re: [Qemu-devel] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function

2019-03-03 Thread Richard Henderson
On 3/3/19 9:23 AM, Mark Cave-Ayland wrote: > Instead of having multiple copies of the offset calculation logic, move it to > a > single vsrl_offset() function. > > This commit also renames the existing get_vsr()/set_vsr() functions to > get_vsrl()/set_vsrl() which better describes their purpose.

[Qemu-devel] [PATCH 2/8] target/ppc: introduce single vsrl_offset() function

2019-03-03 Thread Mark Cave-Ayland
Instead of having multiple copies of the offset calculation logic, move it to a single vsrl_offset() function. This commit also renames the existing get_vsr()/set_vsr() functions to get_vsrl()/set_vsrl() which better describes their purpose. Signed-off-by: Mark Cave-Ayland --- target/ppc/cpu.h