Re: [Qemu-devel] [PATCH 2/8] mips: introduce internal.h and cleanup cpu.h

2017-08-21 Thread Igor Mammedov
On Fri, 18 Aug 2017 17:03:03 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 08/17/2017 12:06 PM, Philippe Mathieu-Daudé wrote: > >>> no logical change, only code movement (and fix a comment typo). > > > >> while at that fix checkpatch errors or > >> first fix checkpatch noted issues

Re: [Qemu-devel] [PATCH 2/8] mips: introduce internal.h and cleanup cpu.h

2017-08-18 Thread Philippe Mathieu-Daudé
Hi Igor, On 08/17/2017 12:06 PM, Philippe Mathieu-Daudé wrote: no logical change, only code movement (and fix a comment typo). while at that fix checkpatch errors or first fix checkpatch noted issues in cpu.h and then move it in next patch to internal.h After asking confirmation on IRC the

Re: [Qemu-devel] [PATCH 2/8] mips: introduce internal.h and cleanup cpu.h

2017-08-17 Thread Philippe Mathieu-Daudé
no logical change, only code movement (and fix a comment typo). while at that fix checkpatch errors or first fix checkpatch noted issues in cpu.h and then move it in next patch to internal.h ok will do!

Re: [Qemu-devel] [PATCH 2/8] mips: introduce internal.h and cleanup cpu.h

2017-08-17 Thread Igor Mammedov
On Thu, 17 Aug 2017 01:30:56 -0300 Philippe Mathieu-Daudé wrote: > no logical change, only code movement (and fix a comment typo). while at that fix checkpatch errors or first fix checkpatch noted issues in cpu.h and then move it in next patch to internal.h > > Signed-off-by: Philippe Mathieu

[Qemu-devel] [PATCH 2/8] mips: introduce internal.h and cleanup cpu.h

2017-08-16 Thread Philippe Mathieu-Daudé
no logical change, only code movement (and fix a comment typo). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h| 354 + target/mips/internal.h | 362 +++ target/mips/cp0_timer.c | 1 +