Re: [Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-13 Thread Alistair Francis
On Tue, Jul 11, 2017 at 6:45 PM, Peter Maydell wrote: > On 11 July 2017 at 16:40, Alistair Francis wrote: >> On Tue, Jul 11, 2017 at 5:33 PM, Peter Maydell >> wrote: >>> On 11 July 2017 at 16:12, Alistair Francis wrote: On Tue, Jul 11, 2017 at 1:17 PM, Peter Maydell wrote: > Im

Re: [Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 21:42, Philippe Mathieu-Daudé wrote: > Hi Peter, > > There is probably no need yet, but we could model a generic APB slave with > this code, as an overlapping subregion (device top 0x30 bytes). > > For now only PID0 differs, but since all ID are 8bit the device could even > inst

Re: [Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-11 Thread Philippe Mathieu-Daudé
Hi Peter, There is probably no need yet, but we could model a generic APB slave with this code, as an overlapping subregion (device top 0x30 bytes). For now only PID0 differs, but since all ID are 8bit the device could even instantiate the subregion with some u64 PID, 32 CID args. (thinking

Re: [Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 16:40, Alistair Francis wrote: > On Tue, Jul 11, 2017 at 5:33 PM, Peter Maydell > wrote: >> On 11 July 2017 at 16:12, Alistair Francis wrote: >>> On Tue, Jul 11, 2017 at 1:17 PM, Peter Maydell >>> wrote: Implement a model of the simple "APB UART" provided in the C

Re: [Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-11 Thread Alistair Francis
On Tue, Jul 11, 2017 at 5:33 PM, Peter Maydell wrote: > On 11 July 2017 at 16:12, Alistair Francis wrote: >> On Tue, Jul 11, 2017 at 1:17 PM, Peter Maydell >> wrote: >>> Implement a model of the simple "APB UART" provided in >>> the Cortex-M System Design Kit (CMSDK). >>> >>> Signed-off-by: Pet

Re: [Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 16:12, Alistair Francis wrote: > On Tue, Jul 11, 2017 at 1:17 PM, Peter Maydell > wrote: >> Implement a model of the simple "APB UART" provided in >> the Cortex-M System Design Kit (CMSDK). >> >> Signed-off-by: Peter Maydell >> +} CMSDKAPBUART; > > This should be CamelCase.

Re: [Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-11 Thread Alistair Francis
On Tue, Jul 11, 2017 at 1:17 PM, Peter Maydell wrote: > Implement a model of the simple "APB UART" provided in > the Cortex-M System Design Kit (CMSDK). > > Signed-off-by: Peter Maydell > --- > hw/char/Makefile.objs| 1 + > include/hw/char/cmsdk-apb-uart.h | 78 > hw/char

[Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-11 Thread Peter Maydell
Implement a model of the simple "APB UART" provided in the Cortex-M System Design Kit (CMSDK). Signed-off-by: Peter Maydell --- hw/char/Makefile.objs| 1 + include/hw/char/cmsdk-apb-uart.h | 78 hw/char/cmsdk-apb-uart.c | 390 ++