Andreas,
thanks for having a look. I no other comments arrive today I will resubmit the
patch
set with all comments addressed.
On 20/07/12 16:06, Andreas Färber wrote:
>> +#ifdef DEBUG_HELPER
>> +printf("KVM: invalid sclp call 0x%x / 0x%" PRIx64 "x\n", sccb,
>> code);
>
> sccb is a po
Am 13.07.2012 12:52, schrieb Christian Borntraeger:
> From: Heinz Graalfs
>
> This adds a more generic infrastructure for handling Service-Call
> requests on s390. Currently we only support a small subset of Read
> SCP Info directly in target-s390x. This patch provides the base
> infrastructure f
On 14/07/12 10:48, Blue Swirl wrote:
+cpu_physical_memory_write(sccb, &work_sccb,
+ be16_to_cpu(work_sccb.h.length));
>>>
>>> Perhaps the DMA helpers should be used instead.
>>>
>>
>> Is there any rule what to use under which circumstances.
>
> No, it's a
On Fri, Jul 13, 2012 at 4:44 PM, Christian Borntraeger
wrote:
> Thanks fpr the review,
>
>
> On 13/07/12 17:08, Blue Swirl wrote:
>
>>> + * Copyright IBM, Corp. 2007, 2012
>>
>> 2007, really?
>
> Well, yes and no. The first userspace for kvm on s390 was kuli and some of
> that
> code was used for
Thanks fpr the review,
On 13/07/12 17:08, Blue Swirl wrote:
>> + * Copyright IBM, Corp. 2007, 2012
>
> 2007, really?
Well, yes and no. The first userspace for kvm on s390 was kuli and some of that
code was used for bringup. But it looks pretty different now, so we can
change that to be 2012 as
On Fri, Jul 13, 2012 at 10:52 AM, Christian Borntraeger
wrote:
> From: Heinz Graalfs
>
> This adds a more generic infrastructure for handling Service-Call
> requests on s390. Currently we only support a small subset of Read
> SCP Info directly in target-s390x. This patch provides the base
> infra
From: Heinz Graalfs
This adds a more generic infrastructure for handling Service-Call
requests on s390. Currently we only support a small subset of Read
SCP Info directly in target-s390x. This patch provides the base
infrastructure for supporting more commands and moves Read SCP
Info.
In the futu
