Re: [Qemu-devel] [PATCH 2/6] bitmap dump code via QAPI framework

2014-05-20 Thread Sanidhya Kashyap
>> +#define QERR_LOG_DIRTY_BITMAP_ACTIVE \ >> +ERROR_CLASS_GENERIC_ERROR, "Dirty bitmap dump already in progress" >> + > > Please don't add new ERROR_CLASS macros. Instead, just use error_setg() > and directly output the error message at the call site that produces the > error. > will keep in

Re: [Qemu-devel] [PATCH 2/6] bitmap dump code via QAPI framework

2014-05-20 Thread Eric Blake
On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote: > This patch introduces the mechanism of dumping the dirty bitmap either > in an ascii format or binary format. The implementation is almost > similar to the migration one. A separate thread is created for the > dumping process. > > The bitmap is obt

[Qemu-devel] [PATCH 2/6] bitmap dump code via QAPI framework

2014-05-20 Thread Sanidhya Kashyap
This patch introduces the mechanism of dumping the dirty bitmap either in an ascii format or binary format. The implementation is almost similar to the migration one. A separate thread is created for the dumping process. The bitmap is obtained with the help of ramlist blocks. I have used almost si