Re: [Qemu-devel] [PATCH 2/5] block/qcow2-bitmap: Allow bitmap flushing

2019-03-08 Thread John Snow
On 3/6/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.03.2019 18:59, John Snow wrote: >> >> >> On 3/6/19 7:58 AM, Eric Blake wrote: >>> On 3/5/19 5:43 PM, John Snow wrote: Usually, we only write out bitmaps when we're about to close out the file, so we always remove the bitmaps

Re: [Qemu-devel] [PATCH 2/5] block/qcow2-bitmap: Allow bitmap flushing

2019-03-06 Thread Vladimir Sementsov-Ogievskiy
06.03.2019 18:59, John Snow wrote: > > > On 3/6/19 7:58 AM, Eric Blake wrote: >> On 3/5/19 5:43 PM, John Snow wrote: >>> Usually, we only write out bitmaps when we're about to close out the file, >>> so we always remove the bitmaps after to make it easier to determine the >>> source of truth for

Re: [Qemu-devel] [PATCH 2/5] block/qcow2-bitmap: Allow bitmap flushing

2019-03-06 Thread John Snow
On 3/6/19 7:58 AM, Eric Blake wrote: > On 3/5/19 5:43 PM, John Snow wrote: >> Usually, we only write out bitmaps when we're about to close out the file, >> so we always remove the bitmaps after to make it easier to determine the >> source of truth for migration purposes. >> >> However, there may

Re: [Qemu-devel] [PATCH 2/5] block/qcow2-bitmap: Allow bitmap flushing

2019-03-06 Thread Eric Blake
On 3/5/19 5:43 PM, John Snow wrote: > Usually, we only write out bitmaps when we're about to close out the file, > so we always remove the bitmaps after to make it easier to determine the > source of truth for migration purposes. > > However, there may be times we want to flush bitmap data more ag

[Qemu-devel] [PATCH 2/5] block/qcow2-bitmap: Allow bitmap flushing

2019-03-05 Thread John Snow
Usually, we only write out bitmaps when we're about to close out the file, so we always remove the bitmaps after to make it easier to determine the source of truth for migration purposes. However, there may be times we want to flush bitmap data more aggressively, like after a truncate event where