Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-10 Thread Vladimir Sementsov-Ogievskiy
08.06.2019 1:08, John Snow wrote: > > > On 6/7/19 2:17 PM, Vladimir Sementsov-Ogievskiy wrote: >> 07.06.2019 21:10, John Snow wrote: >>> >>> >>> On 6/7/19 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: 06.06.2019 21:41, John Snow wrote: > Instead of bdrv_can_store_new_bitmap, rework this

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-07 Thread John Snow
On 6/7/19 2:17 PM, Vladimir Sementsov-Ogievskiy wrote: > 07.06.2019 21:10, John Snow wrote: >> >> >> On 6/7/19 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 06.06.2019 21:41, John Snow wrote: Instead of bdrv_can_store_new_bitmap, rework this as bdrv_add_persistent_dirty_bitmap. Thi

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2019 21:10, John Snow wrote: > > > On 6/7/19 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: >> 06.06.2019 21:41, John Snow wrote: >>> Instead of bdrv_can_store_new_bitmap, rework this as >>> bdrv_add_persistent_dirty_bitmap. This makes a more obvious symmetry >>> with bdrv_remove_persistent_

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-07 Thread Eric Blake
On 6/7/19 1:10 PM, John Snow wrote: > > > On 6/7/19 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: >> 06.06.2019 21:41, John Snow wrote: >>> Instead of bdrv_can_store_new_bitmap, rework this as >>> bdrv_add_persistent_dirty_bitmap. This makes a more obvious symmetry >>> with bdrv_remove_persistent

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2019 21:17, Vladimir Sementsov-Ogievskiy wrote: > 07.06.2019 21:10, John Snow wrote: >> >> >> On 6/7/19 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 06.06.2019 21:41, John Snow wrote: Instead of bdrv_can_store_new_bitmap, rework this as bdrv_add_persistent_dirty_bitmap. This ma

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-07 Thread John Snow
On 6/7/19 10:29 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.06.2019 21:41, John Snow wrote: >> Instead of bdrv_can_store_new_bitmap, rework this as >> bdrv_add_persistent_dirty_bitmap. This makes a more obvious symmetry >> with bdrv_remove_persistent_dirty_bitmap. Most importantly, we are free

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
06.06.2019 21:41, John Snow wrote: > Instead of bdrv_can_store_new_bitmap, rework this as > bdrv_add_persistent_dirty_bitmap. This makes a more obvious symmetry > with bdrv_remove_persistent_dirty_bitmap. Most importantly, we are free > to modify the driver state because we know we ARE adding a bit

Re: [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-06 Thread Eric Blake
On 6/6/19 1:41 PM, John Snow wrote: > Instead of bdrv_can_store_new_bitmap, rework this as > bdrv_add_persistent_dirty_bitmap. This makes a more obvious symmetry > with bdrv_remove_persistent_dirty_bitmap. Most importantly, we are free > to modify the driver state because we know we ARE adding a bi

[Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap

2019-06-06 Thread John Snow
Instead of bdrv_can_store_new_bitmap, rework this as bdrv_add_persistent_dirty_bitmap. This makes a more obvious symmetry with bdrv_remove_persistent_dirty_bitmap. Most importantly, we are free to modify the driver state because we know we ARE adding a bitmap instead of simply being asked if we CAN