Re: [Qemu-devel] [PATCH 2/5] Blackfin: initial port

2013-06-28 Thread Andreas Färber
Hi, Am 17.06.2013 09:16, schrieb Mike Frysinger: > diff --git a/target-bfin/cpu-qom.h b/target-bfin/cpu-qom.h > new file mode 100644 > index 000..697797b > --- /dev/null > +++ b/target-bfin/cpu-qom.h For a new target, a separate cpu-qom.h should be unnecessary - it has become impossible to in

Re: [Qemu-devel] [PATCH 2/5] Blackfin: initial port

2013-06-28 Thread Eric Blake
On 06/17/2013 01:16 AM, Mike Frysinger wrote: > This is the core Blackfin support. While most things work that gcc will > generate, there are notable things missing at this point: > - many dsp/alu/mac insns not supported > - no saturation support > - many astat flags not updated > - probably o

Re: [Qemu-devel] [PATCH 2/5] Blackfin: initial port

2013-06-25 Thread Mike Frysinger
On Tuesday 25 June 2013 17:23:57 Richard Henderson wrote: whee, got a review! :) i've snipped items that were obvious in the "i'll go do this" category rather than just copying & pasting "OK" many times. got a long flight coming up soon, so hopefully i can tackle the majority of this work the

Re: [Qemu-devel] [PATCH 2/5] Blackfin: initial port

2013-06-25 Thread Richard Henderson
> diff --git a/target-bfin/bfin-sim.c b/target-bfin/bfin-sim.c Why this separate file from translate.c? > +#include > +#include > +#include > +#include > +#include > +#include Certainly you shouldn't need these, since this isn't a separately compiled object -- you're included from translat