Re: [Qemu-devel] [PATCH 2/4] target-ppc: implement vnegw/d instructions

2016-10-09 Thread Nikunj A Dadhania
Richard Henderson writes: > On 10/07/2016 01:57 PM, Nikunj A Dadhania wrote: >> +r->element[i] = (~(b->element[i]) + 1) & mask; \ > > Any reason you're not writing this as a proper negate? No particular reason, I was just trying to mimic the pseudo code in the ISA. r->eleme

Re: [Qemu-devel] [PATCH 2/4] target-ppc: implement vnegw/d instructions

2016-10-09 Thread Richard Henderson
On 10/07/2016 01:57 PM, Nikunj A Dadhania wrote: +r->element[i] = (~(b->element[i]) + 1) & mask; \ Any reason you're not writing this as a proper negate? r~

[Qemu-devel] [PATCH 2/4] target-ppc: implement vnegw/d instructions

2016-10-07 Thread Nikunj A Dadhania
Vector Integer Negate Instructions: vnegw: Vector Negate Word vnegd: Vector Negate Doubleword Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 2 ++ target-ppc/int_helper.c | 12 target-ppc/translate/vmx-impl.inc.c | 2 ++ target-ppc/translat